Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed responsive of contributor section #164

Merged
merged 2 commits into from
Jun 5, 2024
Merged

Fixed responsive of contributor section #164

merged 2 commits into from
Jun 5, 2024

Conversation

Ayushmaanagarwal1211
Copy link
Contributor

I've created a responsive contributor section for the website .
closes : #154

Hii there I attached the demo video please see i

bandicam.2024-06-04.22-41-56-439.mp4

Copy link

vercel bot commented Jun 4, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
helpops-hub ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 5, 2024 3:11am

Copy link

github-actions bot commented Jun 4, 2024

Thank you for submitting your pull request! 🙌 We'll review it as soon as possible. In the meantime, please ensure that your changes align with our CONTRIBUTING.md. If there are any specific instructions or feedback regarding your PR, we'll provide them here. Thanks again for your contribution! 😊

Copy link
Owner

@mdazfar2 mdazfar2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Ayushmaanagarwal1211 Great work but i want the intro of our team is good at the alignment of left as desktop view

image

  • It is good at it's place, just leave it there on the desktop view, Do you understand na what I want to say?

@mdazfar2 mdazfar2 added enhancement New feature or request WIP work in progress by other contributor let you know labels Jun 4, 2024
@Ayushmaanagarwal1211
Copy link
Contributor Author

Yes i am correcting it

@Ayushmaanagarwal1211
Copy link
Contributor Author

@sanjay-kv can you check it again i fixed it

bandicam.2024-06-05.08-40-28-873.mp4

Copy link
Owner

@mdazfar2 mdazfar2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mdazfar2 mdazfar2 merged commit 58900da into mdazfar2:main Jun 5, 2024
2 checks passed
@mdazfar2 mdazfar2 added gssoc'24 level2 web enhance try to make web impressive work done great work and removed WIP work in progress by other contributor let you know labels Jun 5, 2024
@mdazfar2
Copy link
Owner

mdazfar2 commented Jun 5, 2024

Hi @Ayushmaanagarwal1211 just i noticed that you are removed color inside from the card color

Screenshot before merge your code

image

Screenshot after merge your changes (The color of this card became completely white.)


image

  • Did you see anything different looking at both of the screenshots?

@Ayushmaanagarwal1211
Copy link
Contributor Author

Ok i am seeing what is happening

@Ayushmaanagarwal1211
Copy link
Contributor Author

oh i found the mistake please wait i will fix it

@mdazfar2
Copy link
Owner

mdazfar2 commented Jun 5, 2024

oh i found the mistake please wait i will fix it


@Ayushmaanagarwal1211 please as soon as complete this issue you can raise an issue on that

@Ayushmaanagarwal1211
Copy link
Contributor Author

Actually I already raised pr please see that

@sanjay-kv sanjay-kv removed the level2 label Jun 16, 2024
@Ayushmaanagarwal1211
Copy link
Contributor Author

@sanjay-kv Sir can i please know why you removed the level

@sanjay-kv
Copy link
Collaborator

image

image
this is basically creating multiple PR to do one single tasks. already level 2 is given for other PR.

@Ayushmaanagarwal1211
Copy link
Contributor Author

@sanjay-kv Sir the website consists of multiple pages including a landing page, a contributor page, a resources page, an FAQ page, an About Us page, and a Contact Us page. I have ensured that all pages are responsive, except for the contributor page due to its high complexity

You can review all discussions and changes made in this pull request. Additionally, please note that the repository contains two versions of the website: the old one and the new one. The pull request for the Contact Us page's responsiveness belongs to the new website. Previous pull requests are for the old website. You can verify this in the repository folder, which contains both Website 1.0 and Website 2.0.

@Ayushmaanagarwal1211
Copy link
Contributor Author

I noticed sir that many levels have been reduced or removed from the pull requests in this repository. I can prove my authenticity for each and every pull request. You can confirm this with mdazfar2, with whom I have connected on Discord. We have had numerous discussions with the owner of the repository regarding these changes.
If you have any concerns about spamming or any inappropriate behavior, please let me know sir . I am ready to provide proof for all my contributions.

@sanjay-kv
Copy link
Collaborator

sanjay-kv commented Jun 18, 2024

i can only change to level1, as I have personally seen this code changes.
I understand your concern on points, the thing is many have reported the same issues to us.

So what if contributors start replicating the same patterns? like a website with 10 pages, make it responsive page by page, and get level 2. this will lead to spamming. I have given level1 for the time being.
I believe there was more than 3 individual responsive PR with level3 that's why normalised score on this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request great work gssoc'24 web enhance try to make web impressive work done
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feat: Contributor Section Responsiveness
3 participants