-
-
Notifications
You must be signed in to change notification settings - Fork 78
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enhanced the Front Page #508
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Thank you for submitting your pull request! 🙌 We'll review it as soon as possible. In the meantime, please ensure that your changes align with our CONTRIBUTING.md. If there are any specific instructions or feedback regarding your PR, we'll provide them here. Thanks again for your contribution! 😊 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Ayushmaanagarwal1211 great work
Merge pull request mdazfar2#508 from Ayushmaanagarwal1211/main
@sanjay-kv Sir i am not understanding how just enhanced word make the work same |
Here i Changed the front page i have added a video and theme is completely different thing from that |
In theme i was talking about the whole website changing to new theme |
Sir this is not fair with me i am giving most of my time and my points getting reduced by just one word sir i know i am not doing anything wrong creating such things take much time i am giving my proper time and after sometime my points are getting reduces |
Ok sir i am sending message their |
Sir but website is changing day by day when i do it first responsive then it doesn't contains blogs section and forum section But now we all are working on developing the blog and forum section so how can i make it responsive |
@sanjay-kv sir, I understand the guidelines, but as a project admin, we are creating pages one by one. A few days ago, we created a page for the DevOps forum, then we made it responsive and added dark mode. After that, we created a backend design for the DevOps forum and implemented it, then we made it responsive and added dark mode again in other issue and PR. As we add pages, we are gradually implementing responsiveness and dark mode. There is no scam; Ayushmaan is working genuinely as I have seen. |
I understand their website is changing, anything beyond that is hard to award. If a proper comment section has been followed it |
Sir so please revert my level back and give me time of one day i will add all title and description for everything properly |
I will also check this with technical team. |
Sir for the tags pr i have created the whole tag page from the scratch their is nothing before like tag in the whole website i just not make it responsive sir but i created the whole new component , Created it responsive adn added dark mode to it |
Sir and their are many things i have did minumum 3 things in each pr i didn't just make it responsive |
|
Ok sir i will add proper Note for reviewers to all my pr's |
The question is how many UI for single repo, 3 is reasonable UI complete change beyond that its fishy. I should have limited this repo max technical contribution to 1500. Now its too late. |
@sanjay-kv sir Please look at the screenshot below with red highlight square box. I have added that Aayushmaan also described the work with dark mode. Dark mode is just a small part of the significant work he has done, like backend integration, functionality of followers and following, and many other things. Please don't focus on the text "Dark mode." He has completed only a few PRs for dark mode and received only level 1. Please look at the description as well. |
|
sir https://www.helpopshub.com/ |
UI is good though |
Yes sir you can check it with your technical team if they found anything same in the code or repeated work i have no problem with that but if my all code are different and they have valid working so please revert it back because you know i am on the top and giving my whole day just to open source and then reducing points without doing anything wrong it will demote the motivation sir |
What im telling is the process you follow is completely wrong to the project admin, we never do this in real time project, You create a figma page with help of UI designer, finish the entire work on the webpage, get it approved. From PM and other contributor perspective we see the commits and change and we feel like its not a fair contribution. |
Sir but this repo is open for all everyone can come here and contribute in this their is not only me i am contributing and i am not stopping any one to contribute sir |
Sir you can share all my pr to the testing team if they say that i did same work then please down else it will not fair with me sir |
Here is list of PR |
@sanjay-kv, Sir, we already have a Figma design and a Canva mockup for the website. I'll share the links for your reference. As you mentioned, the current design lacks responsiveness and dark mode functionality.
Than you |
|
@sanjay-kv, Sir, the screenshot you shared doesn't seem to be related to my repository. I'm not familiar with "Ansh." I believe you might have sent the wrong screenshot by mistake. |
That's the screenshot from guidelines . |
Yes sir I read that but if I am correct then |
@sanjay-kv, Okay, sir! I've familiarized myself with the guidelines since starting the program. I apologize if any mistakes were made on my part. I believe in recognizing hard work and effort. When speaking with contributors on Discord, I can gauge their dedication. If resolving an issue takes significant time, I'll consider assigning a level 3 and nothing else. hope you review our design below. ):
Than you |
this ain't mean to you or your repo, its important this thing to be questioned and have a record of the conversation. |
@sanjay-kv Sir i don't want to increase this conversation but just please give me 5 min and read All this carefully From the Contributors points of view the things we see that
So 2 months before i raised one issue and got assigned and then connected on discord with the @mdazfar2 From the Admin Point of view
Sir and if We talk about that it creates discrimination with other so sir i want to clear one points
And sir Sir if i am giving my whole time and i did contributions even at my exam time so it's my right to get the proper points for the time and effort i am giving And sir we can also connect on a meet where i can explain you live and show the discussions about the project i did with afzar i will reply within 5 min sir by this you can understand the time i am giving to the GSSOC Sir i don't know why are you just judging my whole pr just on the basis of one similar word in the pr it's just the extra thing i am doing please read the full title and description and then if you find duplicacy then remove points |
So i hope sir you will take the decisions accordingly and will assure that nothing unfair will happen with deserving contributor |
@sanjay-kv sir can you just give 5 min to read this
|
These are the technical team comments only for the flagged "responsive" and "dark mode" PR Your contributions are good, but doing multiple contributions is mostly enhancement and carry on work from the existing enhancement made. so we can provide max level 1 or level 2 (if code change and implementation are high) for this. Lets take one example: The below repo you have rewarded level 3. Codebase first of all doesn't worth enough.
this page responsive is mentioned in pr 150. (#150) you already got level 3 to it. The below are some of the comment from technical team of 4
Counselllor/Counsellor-Web#992
Counselllor/Counsellor-Web#1021
Counselllor/Counsellor-Web#1040
Counselllor/Counsellor-Web#1270
|
@sanjay-kv Ok sir i am satisfied with many comments but not with all like sir Like many time or even i already written in the title that i am creating the whole page UI that's the first thing Creating the whole new Page that must get lvl 3 But everyone is judging my PR's On a single word i.e Responsive That's not fair sir i am mentioning the pr's with proper explanation in that i created a whole new Component and added it to website so that it can visible to users Like in #1007Sir here is the image i have created the whole new ui from scratch and also added responsive and dark mode so i completed all that in sinlge pr so IMO level 3 is worth it for creating the whole new UI and attching with the code in #1122I created whole new UI of tags page their is nothing like tags before so i created it from scratch sir in pr #1170Again i created a Competely New Ui for dashboard their is nothing like dashboard in the previous website i just written responsive and dark mode because i completed the whole ui in just one pr sir in this and in above pr's i created a whole new component that doesn't needs in only responsive sir in #1172I Integrated whole UI with backend for the dashboard and make it completely functional sir as creation of the whole dashboard from the scratch can even take 70 points 3 level for its creation and level 2 for its backend integration to fetch real time updates sir in #979 and #974In 979 i created the whole new UI for the followers page that is completed with responsive and dark mode from scratch and then in the new one i integrated the whole backend with it i think sir in combine 50 points are worth it sir in #259 i have integrated the working through email JS not UI I clearly mentioned sir i don't know why my points got reducedsir in #1097I have added a completely new tooltip using new library and fix the image is not showing atleast lvl2 worth it you can ignore responsive #906sir i implemented the whole dark mode for these new sections and i didn't get 200+ more points for dark mode #902sir here again if you ignore responsive i added the dashed border it must get lvl1 sir in #136Again i created whole new FAQ page and got only lvl 1 sir #119again i created a whole new page but lvl 2 is not bad i am satisfied with that PRsir again in this pr i improved the seo by improving the performance then why it got lvl 1 |
Sir and if creation of new component is not worth it for lvl 3 so i know many pr's of other contributor i can mention all that |
Sir i understand your concern about responsive but in many pr's i just added it as a part the main thing is different See the components i have created is complete i doesn't left anything in that and also created from scratch the only concern of my is this only |
@sanjay-kv sir and also for codar hub repo bandicam.2024-07-28.14-48-13-199.mp4SEE on the original leaderboard only 40 points are counted but in your's it is showing more that 150 |
mate i started review from you, i will proceed to them going forward. else when I change labels people points to other people PR. and this is time consuming process. nishant is yet to go through it, I spoke to him saying internal team has done analysis found spam on duplicate issue,he is fine with it. i will do his review tomorrow |
@sanjay-kv Sir i am satisfied with your decision but sir i am having concern with these 5 pr's as according to your testing team the creation of whole new UI should get lvl 3 but sir please just one time read the complete title just ignore responsive and dark mode
sir please see in 1007 i created complete create post UI from scratch responsive doesn't matter here i just added because i created completely Sir my concern is related to only these pr's sir all these pr's are seeing as just responsive but sir responsiveness is just the extra thing i have added please look closely |
and sir @sanjay-kv i saw this today that i created the issue first for filtering the blogs but project admin assigns him and merged that pr and closed that pr Sir i have sended many message but he is online but not replying on a single message |
I have Enhanced the frontpage by giving equal spacing , fixed alignment of all items ,
And created the almost similar design
closes : #505
bandicam.2024-06-19.21-58-57-183.mp4