[GH-773] Jira's autolink should support issue links that contain a comment link in the URL (#773)

[jupriano]

• add autolink config for a comment that has a comment link at the end of the posted URL

[mattermod]

Hello @vicky-demansol,

Thanks for your pull request! A Core Committer will review your pull request soon. For code contributions, you can learn more about the review process here.

Per the Mattermost Contribution Guide, we need to add you to the list of approved contributors for the Mattermost project.

Please help complete the Mattermost contribution license agreement?
Once you have signed the CLA, please comment with /check-cla and confirm that the CLA check is green.

This is a standard procedure for many open source projects.

Please let us know if you have any questions.

We are very happy to have you join our growing community! If you're not yet a member, please consider joining our Contributors community channel to meet other contributors and discuss new opportunities with the core team.

[mickmister]

Hi @vicky-demansol, can you please write unit tests for this so we can see this in action? Are are some example URLs you can use:

Jira Cloud:

• https://mmtest.atlassian.net/browse/DP-454?focusedCommentId=11347

Jira Server:

• http://ec2-54-157-116-101.compute-1.amazonaws.com/browse/DKHPROJ-5?focusedCommentId=10200
• http://ec2-54-157-116-101.compute-1.amazonaws.com/browse/DKHPROJ-5?focusedCommentId=10200&page=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#comment-10200

[codecov-commenter]

Codecov Report

Merging #797 (4db5740) into master (7278600) will decrease coverage by 0.02%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##           master     #797      +/-   ##
==========================================
- Coverage   35.15%   35.13%   -0.03%     
==========================================
  Files          51       51              
  Lines        5825     5829       +4     
==========================================
  Hits         2048     2048              
- Misses       3572     3576       +4     
  Partials      205      205              

Impacted Files	Coverage Δ
server/plugin.go	16.02% <0.00%> (-0.37%)	⬇️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7278600...4db5740. Read the comment docs.

[hanzei]

/check-cla

[mattermod]

This PR has been automatically labelled "stale" because it hasn't had recent activity.
A core team member will check in on the status of the PR to help with questions.
Thank you for your contribution!

/cc @jasonblais @jfrerich @emilyacook

[catalintomai]

Hi @vicky-demansol - this has been stale for a while - are you actively working on it? Any ETA for it? Thanks.

[jupriano]

Hi @vicky-demansol - this has been stale for a while - are you actively working on it? Any ETA for it? Thanks.

still trying writing unit test at https://github.com/mattermost/mattermost-plugin-autolink/blob/master/server/autolink/lib_jira_test.go but get failed unit test

[jupriano]

unit test example https://gist.github.com/vicky-demansol/01f54856c806fba75624e9afd84d29da write on https://github.com/mattermost/mattermost-plugin-autolink/blob/master/server/autolink/lib_jira_test.go I don't know where exactly I need to write the unit test

[mickmister]

@vicky-demansol You can add it to the test as you did your gist. For future reference, you can commit this sort of code to the PR and request feedback that way

[jupriano]

@vicky-demansol You can add it to the test as you did your gist. For future reference, you can commit this sort of code to the PR and request feedback that way

can I PR without any issue there https://github.com/mattermost/mattermost-plugin-autolink/blob/master/server/autolink

[mickmister]

Hi @vicky-demansol, please mention me so I can get a notification for this discussion 🙂. Feel free to create an issue in the Autolink repository to write the unit test.

[jupriano]

Hi @mickmister i was add the unit test at mattermost-community/mattermost-plugin-autolink#175

[sibasankarnayak]

LGTM !
blocking on this comment here

[mattermod]

This PR has been automatically labelled "stale" because it hasn't had recent activity.
A core team member will check in on the status of the PR to help with questions.
Thank you for your contribution!

/cc @BenLloydPearson @aspleenic

[hanzei]

@mickmister @jfrerich Gentle reminder to review this PR

[mickmister]

@hanzei This is blocked by mattermost-community/mattermost-plugin-autolink#175 (review)

[mattermod]

This PR has been automatically labelled "stale" because it hasn't had recent activity.
A core team member will check in on the status of the PR to help with questions.
Thank you for your contribution!

/cc @aspleenic

[sibasankarnayak]

Will Pick this Up