[GH-174] Add Jira Autolink With Comment (#174) #175

jupriano · 2021-11-10T14:01:17Z

Summary

Aims to add unit test for mattermost/mattermost-plugin-jira#797

Ticket Link

mattermod · 2021-11-10T14:01:21Z

Hello @vicky-demansol,

Thanks for your pull request! A Core Committer will review your pull request soon. For code contributions, you can learn more about the review process here.

mickmister · 2021-11-10T19:12:04Z

server/autolink/lib_jira_test.go

+	{
+		"Jump To Comment With Jira Cloud",
+		autolink.Autolink{
+			Pattern:  "(https://mmtest.atlassian.net/browse/)(DP)(-)(?P<jira_id>\\d+)[?](focusedCommentId)(=)(?P<comment_id>\\d+)",


Is it possible for us to have this regex be project-agnostic? This way it can work with on-prem Jira instances with no changes needed. I discussed this in the Jira plugin issue here mattermost/mattermost-plugin-jira#773 (comment). Please me know if this is possible because I'm not sure if it is.

Also, it possible to write a test for the_change that was done for the Jira plugin PR? The goal would be to initialize the autolink plugin with the old Jira autolink config, then update it using setLink, then assert the Looks like we'll need to test this function https://github.com/mattermost/mattermost-plugin-autolink/blob/571d6cd3c642b23c2a6aa1d4fa50cc5965fa1b20/server/api/api.go#L90

@DHaussermann We'll need to test the upgrade path of the Jira plugin that introduces this functionality.

@mickmister take a look at #175 (comment) and see if it is ok.

mickmister · 2021-11-19T02:53:19Z

server/autolink/lib_jira_test.go

+			Pattern:  "(https://mmtest.atlassian.net/browse/)(DP)(-)(?P<jira_id>\\d+)[?](focusedCommentId)(=)(?P<comment_id>\\d+)",
+			Template: "[DP-${jira_id} With Focused Comment($comment_id)](https://mmtest.atlassian.net/browse/DP-${jira_id}?focusedCommentId=$comment_id)",
+		},
+		"https://mmtest.atlassian.net/browse/DP-454?focusedCommentId=11347",


Can we write a test that doesn't have focusedCommentId in the URL, to test that the regular issue link case works?

#175 (comment) should cover it as well I think.

codecov-commenter · 2021-11-25T14:52:00Z

Codecov Report

Merging #175 (6a837f4) into master (571d6cd) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #175   +/-   ##
=======================================
  Coverage   41.49%   41.49%           
=======================================
  Files           6        6           
  Lines         670      670           
=======================================
  Hits          278      278           
  Misses        375      375           
  Partials       17       17

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 571d6cd...6a837f4. Read the comment docs.

jupriano · 2021-11-26T01:50:54Z

server/autolink/lib_jira_test.go

+		},
+		"https://mmtest.atlassian.net/browse/DP-454",
+		"https://mmtest.atlassian.net/browse/DP-454",
+	},


hi @mickmister did you mean it will be like this ?

Since we want to continue to be able to transform regular issue URLs like this one above, we'll need to incorporate the existing regexes used in the Jira plugin repo here in these tests. One of the existing regexes defined in the Jira plugin is able to parse this URL in the test above.

Since we have 3 regexes now, we need to have 3x3 = 9 unit tests for the following:

The first regex correctly transforms a link its meant to transform

The first regex does not change a link that the second regex is meant to transform

The first regex does not change a link that the third regex is meant to transform

and so on for the second and third regexes, for a total of 9 tests.

Also, the regexes in the Jira plugin use the Jira instance's URL in the Pattern, so you'll want to do that here as well, instead of using ?P<URI>.*/.

hanzei · 2021-11-30T11:15:55Z

@vicky-demansol Heads up that CI is failing: https://circleci.com/workflow-run/d28cd0ca-8f16-4652-8eef-dc0628e52a38?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-checks-link

mattermod · 2021-12-12T01:01:08Z

This PR has been automatically labelled "stale" because it hasn't had recent activity.
A core team member will check in on the status of the PR to help with questions.
Thank you for your contribution!

/cc @BenLloydPearson @aspleenic

mickmister

Thanks @jupriano

I've added a few requests, including one to write a total of 9 unit tests for the 3 regexes we have in the Jira plugin now https://github.com/mattermost/mattermost-plugin-jira/blob/4db5740c99a287423f72279d46604c0d8d30c0b2/server/plugin.go#L359-L373, testing that each regex only affects links that are intended for that specific regex

mickmister · 2021-12-15T07:38:56Z

server/autolink/lib_jira_test.go

+		"Trial With Jira Server #1",
+		autolink.Autolink{
+			Pattern:  "(?P<URI>.*/)(?P<IssueKey>[A-Za-z]+-[0-9]+)[?](focusedCommentId=*(?P<FocusedCommentId>[^\\s&]+))",
+			Template: "[${IssueKey} FocusedComment(${FocusedCommentId})](${URI}${IssueKey}?focusedCommentId=${FocusedCommentId})",


I think just putting (comment) in the link text is enough to show that it's a comment

Suggested change

Template: "[${IssueKey} FocusedComment(${FocusedCommentId})](${URI}${IssueKey}?focusedCommentId=${FocusedCommentId})",

Template: "[${IssueKey} (comment)](${URI}${IssueKey}?focusedCommentId=${FocusedCommentId})",

mickmister · 2021-12-15T07:52:28Z

server/autolink/lib_jira_test.go

+			Template: "[${IssueKey} FocusedComment(${FocusedCommentId})](${URI}${IssueKey}?focusedCommentId=${FocusedCommentId})",
+		},
+		"http://ec2-54-157-116-101.compute-1.amazonaws.com/browse/DKHPROJ-5?focusedCommentId=10200&page=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#comment-10200",
+		"http://ec2-54-157-116-101.compute-1.amazonaws.com/browse/DKHPROJ-5?focusedCommentId=10200&page=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#comment-10200",


Can we use the regex to "match" the rest of the URL automatically?

mickmister · 2021-12-15T07:54:47Z

server/autolink/lib_jira_test.go

+		},
+		"https://mmtest.atlassian.net/browse/DP-454",
+		"https://mmtest.atlassian.net/browse/DP-454",
+	},


Since we want to continue to be able to transform regular issue URLs like this one above, we'll need to incorporate the existing regexes used in the Jira plugin repo here in these tests. One of the existing regexes defined in the Jira plugin is able to parse this URL in the test above.

Since we have 3 regexes now, we need to have 3x3 = 9 unit tests for the following:

The first regex correctly transforms a link its meant to transform

The first regex does not change a link that the second regex is meant to transform

The first regex does not change a link that the third regex is meant to transform

and so on for the second and third regexes, for a total of 9 tests.

Also, the regexes in the Jira plugin use the Jira instance's URL in the Pattern, so you'll want to do that here as well, instead of using ?P<URI>.*/.

sibasankarnayak · 2022-03-03T14:10:28Z

closing this and raising a new PR

[mattermost-communityGH-174] Add Jira Autolink With Comment (mattermo…

a49f2c3

…st-community#174)

jupriano requested a review from levb as a code owner November 10, 2021 14:01

jupriano mentioned this pull request Nov 10, 2021

[GH-773] Jira's autolink should support issue links that contain a comment link in the URL (#773) mattermost/mattermost-plugin-jira#797

Closed

hanzei added the 2: Dev Review Requires review by a core committer label Nov 10, 2021

hanzei requested a review from mickmister November 10, 2021 15:05

levb approved these changes Nov 19, 2021

View reviewed changes

mickmister reviewed Nov 19, 2021

View reviewed changes

[mattermost-communityGH-174] Add Trial Regex For Example

4b94f18

jupriano commented Nov 26, 2021

View reviewed changes

hanzei added the 3: QA Review Requires review by a QA tester label Nov 30, 2021

[mattermost-communityGH-174] Add Trial Regex For Example

6a837f4

mattermod added the Lifecycle/1:stale label Dec 12, 2021

mickmister requested changes Dec 15, 2021

View reviewed changes

hanzei added the Awaiting Submitter Action Blocked on the author label Jan 24, 2022

hanzei assigned sibasankarnayak Feb 15, 2022

hanzei added this to the v1.4.0 milestone Feb 15, 2022

hanzei mentioned this pull request Mar 1, 2022

[issue 773] Jira's autolink should support issue links that contain a comment link in the URL mattermost/mattermost-plugin-jira#839

Closed

sibasankarnayak closed this Mar 3, 2022

mattermod removed the Awaiting Submitter Action Blocked on the author label Mar 3, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[GH-174] Add Jira Autolink With Comment (#174) #175

[GH-174] Add Jira Autolink With Comment (#174) #175

jupriano commented Nov 10, 2021

mattermod commented Nov 10, 2021

mickmister Nov 10, 2021

jupriano Dec 14, 2021

mickmister Nov 19, 2021

jupriano Dec 14, 2021

codecov-commenter commented Nov 25, 2021 •

edited

Loading

jupriano Nov 26, 2021

mickmister Dec 15, 2021

hanzei commented Nov 30, 2021

mattermod commented Dec 12, 2021

mickmister left a comment

mickmister Dec 15, 2021

mickmister Dec 15, 2021

mickmister Dec 15, 2021

sibasankarnayak commented Mar 3, 2022

	Template: "[${IssueKey} FocusedComment(${FocusedCommentId})](${URI}${IssueKey}?focusedCommentId=${FocusedCommentId})",
	Template: "[${IssueKey} (comment)](${URI}${IssueKey}?focusedCommentId=${FocusedCommentId})",

[GH-174] Add Jira Autolink With Comment (#174) #175

[GH-174] Add Jira Autolink With Comment (#174) #175

Conversation

jupriano commented Nov 10, 2021

Summary

Ticket Link

mattermod commented Nov 10, 2021

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

codecov-commenter commented Nov 25, 2021 • edited Loading

Codecov Report

Choose a reason for hiding this comment

Choose a reason for hiding this comment

hanzei commented Nov 30, 2021

mattermod commented Dec 12, 2021

mickmister left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

sibasankarnayak commented Mar 3, 2022

codecov-commenter commented Nov 25, 2021 •

edited

Loading