Add the ability to buffer commands #88
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ukendio
reviewed
Jul 16, 2024
|
CI will pass with #89 |
Ukendio
requested changes
Jul 22, 2024
LastTalon
reviewed
Jul 23, 2024
LastTalon
reviewed
Jul 23, 2024
LastTalon
previously requested changes
Jul 26, 2024
|
I am unsure, so I didn't mention anything in review, but it seems like we fail at tracking the correct size of the world in some places. Can you double check this? And do we have tests for this? |
I've checked and I believe everything is fine - I've added a test for this in deferred mode. |
Ukendio
reviewed
Jul 29, 2024
Ukendio
previously approved these changes
Aug 7, 2024
Merged
Ukendio
approved these changes
Aug 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
This PR adds an optional command buffer to Matter's registry. The command buffer caches insertions, removals, spawns, and despawns until explicitly told to apply them. It is enabled by default if you use a
Loopand will commit changes between systems.The old system that prevented iterator invalidation has been replaced with this, but that is not the only motivation for a command buffer.
Related issues
TODO
Additional comments
This is a fairly breaking change even if you don't elect to use it. Educational materials will be important