Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

world:remove(...) should not return anything #93

Open
memorycode opened this issue Jul 27, 2024 · 0 comments
Open

world:remove(...) should not return anything #93

memorycode opened this issue Jul 27, 2024 · 0 comments
Labels
improvement An imperfection we can make better

Comments

@memorycode
Copy link
Contributor

memorycode commented Jul 27, 2024

Current behavior

Calling world:remove(entityId, A) will try to return the instance of A that was removed.

Proposed improvement

The introduction of command buffering means that world:remove() is no longer guaranteed to return exactly what was removed. It is possible that there is a command in the buffer that alters the data.

Because of this, I believe that world:remove() should not return anything.

Additional context

I'm not sure how many people make use of this functionality but it should be considered deprecated for now.

@memorycode memorycode added the improvement An imperfection we can make better label Jul 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
improvement An imperfection we can make better
Projects
None yet
Development

No branches or pull requests

1 participant