[R4R]-fix: contract call estimate gas bug #79
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bug case:
When calling across contracts, an opCall call error out of gas will occur. However, this error is not execution reverted, causing the error and cannot be captured by the call stack. Therefore, when subsequent opcode is executed, opRevert is triggered because the return value is not the expected value. But if this error is triggered during the bisection process, it can be tolerated because smaller gas is used in the estimation.
How to fix
Therefore, the function of this flag is that as long as estimateGas is successful once during the bisection process, it will not terminate. The process of bisection and throwing an evm error (drawing on the idea of Ethereum, using the largest balance to estimate once, if successful, no subsequent judgment errors will be made, if failed, an exception will be thrown directly)
Refund codes
Steps:
_amount=1