Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Output better error message for flash_proxy. #79

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Output better error message for flash_proxy. #79

wants to merge 1 commit into from

Conversation

mithro
Copy link
Contributor

@mithro mithro commented Oct 8, 2017

No description provided.

@sbourdeauducq
Copy link
Member

Please use new-style format ("".format()).

@mithro
Copy link
Contributor Author

mithro commented Oct 9, 2017

Done, but I wasn't really sure how to test I didn't break things?

jordens
jordens requested changes Nov 9, 2017
View reviewed changes
Copy link
Member

@jordens jordens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm ok with saying what file we are looking for. But telling the user about all the different places it could have been is excessive. That's information I'd expect in the documentation of the programmers (i.e. Place the proxy bitstreams in X).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jordens jordens jordens requested changes

@sbourdeauducq sbourdeauducq Awaiting requested review from sbourdeauducq

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mithro @sbourdeauducq @jordens