-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Send "original" URL as src attribute #68
base: main
Are you sure you want to change the base?
Conversation
I understand the fix you're trying to implement here, however this will impact some of the flexibility that the library provides. By defining a base image without any customization options from the This will not be an issue from any of the images from the Could you elaborate on the specific way this fixes the issue in the library? If we know the root cause of the issue, we may be able to come up with a fix which doesn't impact the customizability of the library. |
The passed The |
@lorenzodejong I've updated the tests, but I am unsure if they are actually worth having anymore. It's the loader function result which should be tested. |
Resolves #50
Next.js sends an error if
src
is the same as the optimized image.In this case, we sent the optimized src attribute back to the
getImgProps
function