Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Next.js warning for image loader #67

Closed
wants to merge 4 commits into from

Conversation

andershagbard
Copy link
Contributor

@lorenzodejong
Copy link
Owner

Could you elaborate on what this change does specifically, and how it solved the image loader issue?

@andershagbard
Copy link
Contributor Author

andershagbard commented Jul 11, 2024

Next.js has a check to ensure that the loader uses it's properties. Therefore the warning.

https://github.com/vercel/next.js/blob/00ed837bb4b71ce0c30256e4d07638225b31a7e5/packages/next/src/shared/lib/get-img-props.ts#L529

Unsure why the build fails

@lorenzodejong
Copy link
Owner

lorenzodejong commented Jul 12, 2024

@andershagbard based on the linked source code from Next.js, I don't see how this would solve the explicit issue triggering the error indicating the loader does not implement the width.

Could you elaborate on the specific fix you're introducing here and how it relates to the code path you linked in the Next.js Image source code?

I'll look into the failing build, seems like an issue in the pipeline setup.

@andershagbard
Copy link
Contributor Author

Found the actual issue.

Closed in favor of: #68

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants