onlyoffice rework #650
Merged
onlyoffice rework #650
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
didn't work, and no real point
ericlinagora
force-pushed
the
525-515-548-523-onlyoffice-rework
branch
from
279694a
to
e2ec557
Compare
ericlinagora
force-pushed
the
525-515-548-523-onlyoffice-rework
branch
from
e2ec557
to
630d266
Compare
This was
linked to
issues
Sep 28, 2024
shepilov
reviewed
Sep 30, 2024
shepilov
reviewed
Sep 30, 2024
shepilov
reviewed
Sep 30, 2024
...c/core/platform/services/database/services/orm/connectors/postgres/postgres-query-builder.ts
Show resolved
Hide resolved
shepilov
reviewed
Sep 30, 2024
shepilov
reviewed
Sep 30, 2024
| getPluginKeyStatus: (key: string) => Promise<ApplicationEditingKeyStatus>; | ||
| }, | ||
| attemptCount = 8, | ||
| tarpitS = 1, |
There was a problem hiding this comment.
tarpit?? reviewing you prs is always an English lesson for me
There was a problem hiding this comment.
shepilov
reviewed
Sep 30, 2024
| const swapResult = await provider.atomicSet(newKey, null); | ||
| logger.debug(`Begin edit try ${newKey}, got: ${JSON.stringify(swapResult)}`); | ||
| if (swapResult.didSet) return newKey; | ||
| if (!swapResult.currentValue) continue; // glitch in the matrix but ok because atomicCompareAndSet is not actually completely atomic |
There was a problem hiding this comment.
Why it's not completely atomic?
There was a problem hiding this comment.
There was a problem hiding this comment.
oh yeah, it's a current value that is not atomic at all
shepilov
reviewed
Sep 30, 2024
shepilov
reviewed
Sep 30, 2024
shepilov
reviewed
Sep 30, 2024
shepilov
reviewed
Sep 30, 2024
| const userIdBuffer = UUIDTools.bufferFromUUIDString(userId) as unknown as Uint8Array; | ||
| const companyIdBuffer = UUIDTools.bufferFromUUIDString(companyId) as unknown as Uint8Array; | ||
| const entropyBuffer = UUIDTools.bufferFromUUIDString(randomUUID()) as unknown as Uint8Array; | ||
| const idsString = OnlyOfficeSafeDocKeyBase64.fromBuffer( |
There was a problem hiding this comment.
and also why do we need all this tricky conversions, uuid to hex, and then back to uuid?
There was a problem hiding this comment.
Just using strings with available chars would be bigger than OO allows for key formats. Also because I want editing_session_keys to be sortable by timestamp lexicographically so we can batch work on the older ones
shepilov
reviewed
Sep 30, 2024
shepilov
reviewed
Sep 30, 2024
shepilov
reviewed
Sep 30, 2024
shepilov
approved these changes
Oct 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#525 #515 #548 #523
This is a rewrite to have a more robust connexion with only office, recovering forgotten files, handling editing sessions as global locks, that kind