Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Too many version for the file are created during the file editing in the onlyOffice #525

Closed
shepilov opened this issue May 13, 2024 · 1 comment · Fixed by #650
Closed

Too many version for the file are created during the file editing in the onlyOffice #525

shepilov opened this issue May 13, 2024 · 1 comment · Fixed by #650
Assignees
@ericlinagora
Labels
bug Something isn't working

Comments

@shepilov
Copy link
Member

No description provided.

@shepilov shepilov added the bug Something isn't working label May 13, 2024
@ericlinagora ericlinagora self-assigned this Jun 6, 2024
@ericlinagora
Copy link
Contributor

I think the best option is to have a configurable window of time, if the same application creates versions within that window, they get squashed into just the latest by the app, with a maximum total... eg.: "merge all saves less than 5 minutes apart, but keep at least one version per 30m" or such. Configurable because I expect some tuning required. I think this strategy is most generic and safe (eg. wrt to multi user stuff) - but, and this is a huge "but", it does absolutely nothing for the server load (just, storage space), it's purely UX cleanup

ericlinagora added a commit that referenced this issue Jun 20, 2024
@ericlinagora
✨ backend: Adding atomicCompareAndSet operation to DB connector (#525)
7718421
ericlinagora added a commit that referenced this issue Jun 20, 2024
@ericlinagora
🗃️ DriveFile: add editing_session_key column (#525)
83a4dd1
ericlinagora added a commit that referenced this issue Jun 20, 2024
@ericlinagora
✅ Test for Repository.atomicCompareAndSet (#525)
8477bbc
ericlinagora added a commit that referenced this issue Jul 1, 2024
@ericlinagora
🐛 backend: adding editing session key (#525)
273f759
ericlinagora added a commit that referenced this issue Jul 9, 2024
@ericlinagora
♻️🎨 connector: light cleanup, load (#525)
7cbb6d0 
renaming logger, adding health endpoint, working with old API,
removing aggressive force save stuff, missing forgotten files etc,
documentation
ericlinagora added a commit that referenced this issue Jul 10, 2024
@ericlinagora
💄✅ backend: fix compiler issue and e2e pg connector (#525)
5320ad6
ericlinagora added a commit that referenced this issue Jul 11, 2024
@ericlinagora
✨ backend: Adding atomicCompareAndSet operation to DB connector (#525)
f30f00b
ericlinagora added a commit that referenced this issue Jul 11, 2024
@ericlinagora
🗃️ DriveFile: add editing_session_key column (#525)
4180855
ericlinagora added a commit that referenced this issue Jul 11, 2024
@ericlinagora
✅ Test for Repository.atomicCompareAndSet (#525)
9d4c17d
ericlinagora added a commit that referenced this issue Jul 11, 2024
@ericlinagora
🐛 backend: adding editing session key (#525)
0d7a319
ericlinagora added a commit that referenced this issue Jul 11, 2024
@ericlinagora
♻️🎨 connector: light cleanup, load (#525)
14fdbb2 
renaming logger, adding health endpoint, working with old API,
removing aggressive force save stuff, missing forgotten files etc,
documentation
ericlinagora added a commit that referenced this issue Jul 11, 2024
@ericlinagora
💄✅ backend: fix compiler issue and e2e pg connector (#525)
153e819
ericlinagora added a commit that referenced this issue Jul 11, 2024
@ericlinagora
✨ backend: Adding atomicCompareAndSet operation to DB connector (#525)
e5c12a0
ericlinagora added a commit that referenced this issue Jul 11, 2024
@ericlinagora
🗃️ DriveFile: add editing_session_key column (#525)
f1dcb15
ericlinagora added a commit that referenced this issue Jul 11, 2024
@ericlinagora
✅ Test for Repository.atomicCompareAndSet (#525)
3de9829
ericlinagora added a commit that referenced this issue Jul 11, 2024
@ericlinagora
🐛 backend: adding editing session key (#525)
16dbf80
ericlinagora added a commit that referenced this issue Jul 11, 2024
@ericlinagora
♻️🎨 connector: light cleanup, load (#525)
92aad86 
renaming logger, adding health endpoint, working with old API,
removing aggressive force save stuff, missing forgotten files etc,
documentation
ericlinagora added a commit that referenced this issue Jul 11, 2024
@ericlinagora
💄✅ backend: fix compiler issue and e2e pg connector (#525)
e628c68
ericlinagora added a commit that referenced this issue Jul 11, 2024
@ericlinagora
🚧 WIP: backend: beginnings of a transactional editing for plugins (#525)
329679a
ericlinagora added a commit that referenced this issue Jul 13, 2024
@ericlinagora
🚨🩹 ooconnector: pass linter, fix bug where ignored promises in poller…
532550d 
… caused crash (#525)
ericlinagora added a commit that referenced this issue Jul 16, 2024
@ericlinagora
✨ ooconnector: poll forgotten files, wip: extract code from oocallbac…
89bb7f8 
…k to call here (#525)
ericlinagora added a commit that referenced this issue Jul 16, 2024
@ericlinagora
✨ ooconnector: poll forgotten files, wip: extract code from oocallbac…
df01022 
…k to call here (#525)
ericlinagora added a commit that referenced this issue Jul 17, 2024
@ericlinagora
🚧 ooconnector: show forgotten files in health endpoint for debugging (#…
b4b22f2 
…525)
ericlinagora added a commit that referenced this issue Jul 18, 2024
@ericlinagora
♻️ backend: move editing_session_key generation and parsing to specif…
2fc212a 
…ic implementation (#525)
ericlinagora added a commit that referenced this issue Jul 18, 2024
@ericlinagora
♻️ backend: move editing_session_key generation and parsing to specif…
77adac2 
…ic implementation (#525)
ericlinagora added a commit that referenced this issue Jul 21, 2024
@ericlinagora
♻️ backend: move editing_session_key generation and parsing to specif…
8a30a44 
…ic implementation (#525)
ericlinagora added a commit that referenced this issue Aug 25, 2024
@ericlinagora
🚧 WIP: backend: beginnings of a transactional editing for plugins (#525)
d7eea89
ericlinagora added a commit that referenced this issue Sep 17, 2024
@ericlinagora
♻️ backend,oo: split endEditing into add version and actual end, via …
816fb58 
…"updateEditing" (#525)
ericlinagora added a commit that referenced this issue Sep 17, 2024
@ericlinagora
♻️ oo-connector: wip on callbacks and key reactions, and minor cleanup (
7b78c32 
#525)
ericlinagora added a commit that referenced this issue Sep 18, 2024
@ericlinagora
✨ oo-connector: OO forgotten files batch processor, and testing, but …
18f9208 
…WIP (#525)
ericlinagora added a commit that referenced this issue Sep 18, 2024
@ericlinagora
♻️ oo-connector: centralising forgotten file batch management with se…
6685b7b 
…ssion key check, bit of health refactoring (#525)
ericlinagora added a commit that referenced this issue Sep 18, 2024
@ericlinagora
♻️ oo-connector: single request endediting, refactor URLs, bit of log…
488d5a5 
…ging (#525)
ericlinagora added a commit that referenced this issue Sep 18, 2024
@ericlinagora
♻️ oo-connector: refactored health (#525)
be10393
ericlinagora added a commit that referenced this issue Sep 18, 2024
@ericlinagora
♻️ backend: fix e2e editing session test, make ApplicationApiService …
0680bef 
…a singleton (#525)
ericlinagora added a commit that referenced this issue Sep 18, 2024
@ericlinagora
♻️ backend: fix e2e editing session test, make ApplicationApiService …
9db0fdd 
…a singleton (#525)
ericlinagora added a commit that referenced this issue Sep 18, 2024
@ericlinagora
🩹 backend,oo: fixed begin editing session process (#525)
118e6a0
@ericlinagora ericlinagora mentioned this issue Sep 18, 2024
Merged
ericlinagora added a commit that referenced this issue Sep 18, 2024
@ericlinagora
🩹 backend,oo: fixed begin editing session process (#525)
c239843
ericlinagora added a commit that referenced this issue Sep 18, 2024
@ericlinagora
✅ backend: mock oo-connector response to fix an e2e test (#525)
1ee4f57
ericlinagora added a commit that referenced this issue Sep 18, 2024
@ericlinagora
📝 doc: bit of documentation about the editing session key system for …
021d82c 
…plugins (#525)
ericlinagora added a commit that referenced this issue Sep 19, 2024
@ericlinagora
🩹 cli: fix details of editing_session list command (#525)
d353ec8
ericlinagora added a commit that referenced this issue Sep 19, 2024
@ericlinagora
🐛 backend: when adding a FileVersion, update DriveFile.last_modified (#…
5ae1782 
…525)
ericlinagora added a commit that referenced this issue Sep 19, 2024
@ericlinagora
🩹 backend,oo: adding userId override for application updatingEditingS…
c855c29 
…ession (#525)
ericlinagora added a commit that referenced this issue Sep 19, 2024
@ericlinagora
🚨 oo-connector: minor linter cleanup (#525)
b6d66d6
ericlinagora added a commit that referenced this issue Sep 19, 2024
@ericlinagora
🩹 oo-connector: respect user picked by OO for callback url in updateS…
c0182cf 
…ession (#525)
ericlinagora added a commit that referenced this issue Sep 19, 2024
@ericlinagora
⚰️ backend: deleting rather quite boring file (#525)
ea18aaf
ericlinagora added a commit that referenced this issue Sep 19, 2024
@ericlinagora
♻️🩹 backend,oo: fixing instances of controllers, and wip rename from …
5285de4 
…drive -> oo (#525)
ericlinagora added a commit that referenced this issue Sep 19, 2024
@ericlinagora
🩹 backend,oo: support file renaming from twake drive (#525)
8f5a6c6
ericlinagora added a commit that referenced this issue Sep 19, 2024
@ericlinagora
🩹 backend,oo: minor fixes for file renames (#525)
a40cb7e
ericlinagora added a commit that referenced this issue Sep 23, 2024
@ericlinagora
♻️ oo-connector: use drive_file_id as much as possible in OO flow (#525)
ebe8a78
ericlinagora added a commit that referenced this issue Sep 23, 2024
@ericlinagora
✨ oo-connector: rename from OO (#525)
528d883
ericlinagora added a commit that referenced this issue Sep 23, 2024
@ericlinagora
💄 frontend: remove exit from trash context menu entry (#525)
1a43a75 
didn't work, and no real point
ericlinagora added a commit that referenced this issue Sep 24, 2024
@ericlinagora
✨ cli: add editing_session parse to output key information (#525)
d86165d
ericlinagora added a commit that referenced this issue Sep 26, 2024
@ericlinagora
📝 documentation: describing editing_session_key in more detail (#525)
e7e4db6
@ericlinagora ericlinagora linked a pull request Sep 28, 2024 that will close this issue
onlyoffice rework #650
Merged
ericlinagora added a commit that referenced this issue Oct 2, 2024
@ericlinagora
onlyoffice rework (#650)
b43ef3f 
 #525 #515 #548 #523

This is a rewrite to have a more robust connexion with only office,
recovering forgotten files, handling editing sessions as global locks,
that kind
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ericlinagora ericlinagora

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

onlyoffice rework linagora/twake-drive
2 participants
@shepilov @ericlinagora