New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: gracefully handle remote stream closure during ping #2822

Merged

achingbrain merged 2 commits into main from ping_stream_end

Nov 15, 2024

Merged

fix: gracefully handle remote stream closure during ping #2822

fix: handle stream closing gracefully

Codecov / codecov/patch succeeded Nov 15, 2024 in 0s

82.60% of diff hit (target 92.36%)

View this Pull Request on Codecov

82.60% of diff hit (target 92.36%)

Annotations

Check warning on line 88 in packages/protocol-ping/src/ping.ts

codecov / codecov/patch

packages/protocol-ping/src/ping.ts#L87-L88

Added lines #L87 - L88 were not covered by tests

Check warning on line 105 in packages/protocol-ping/src/ping.ts

codecov / codecov/patch

packages/protocol-ping/src/ping.ts#L104-L105

Added lines #L104 - L105 were not covered by tests

View more details on Codecov