Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: gracefully handle remote stream closure during ping #2822

Merged
merged 2 commits into from
Nov 15, 2024

Conversation

achingbrain
Copy link
Member

This PR fixes the UnexpectedEOFError issue. This issue happens because the ping protocol does not handle the case where the remote peer closes the stream and with the introduction of connectionMonitor this became an issue. It opens a stream for the ping protocol, sends a ping, gets the response then closes the stream. The local peer throws an exception and triggers a yamux reset.

Change checklist

  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation if necessary (this includes comments as well)
  • I have added tests that prove my fix is effective or that my feature works

@achingbrain achingbrain requested a review from a team as a code owner November 15, 2024 12:04
@achingbrain achingbrain changed the title fix(ping): gracefully handle remote stream closure. fix: gracefully handle remote stream closure during ping Nov 15, 2024
@achingbrain achingbrain merged commit 4db0645 into main Nov 15, 2024
35 checks passed
@achingbrain achingbrain deleted the ping_stream_end branch November 15, 2024 16:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants