Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added PHP 8.4 Support #39

Open
wants to merge 8 commits into
base: 3.8.x
Choose a base branch
from
Open

Added PHP 8.4 Support #39

Show file tree
Hide file tree
Changes from 5 commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
12c9572
Added PHP 8.4 Support
manishranjan-adobe Oct 10, 2024
c1d3631
corrected composer.lock file issues
manishranjan-adobe Oct 15, 2024
5715f4a
ignore platform requirements
manishranjan-adobe Oct 17, 2024
910a932
Fix MD001/heading-increment Heading levels issue
manishranjan-adobe Oct 17, 2024
b8c72ef
Upgraded dev dependency
manishranjan-adobe Oct 21, 2024
ac1b3f9
Slight change in wording in MD file
manishranjan-adobe Oct 23, 2024
daaf4f1
Reverted incremental line heading code changes
manishranjan-adobe Oct 23, 2024
4ef10b6
Removed 8.3 platform dependency requirement
manishranjan-adobe Oct 23, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion .laminas-ci.json
View file
Open in desktop
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing a new line at the end of the file.

Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
{
"ignore_php_platform_requirements": {
"8.3": true
"8.3": true,
"8.4": true
manishranjan-adobe marked this conversation as resolved.
Show resolved Hide resolved
}
}
10 changes: 5 additions & 5 deletions composer.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,18 +16,18 @@
"rss": "https://github.com/laminas/laminas-recaptcha/releases.atom"
},
"require": {
"php": "~8.0.0 || ~8.1.0 || ~8.2.0 || ~8.3.0",
"php": "~8.0.0 || ~8.1.0 || ~8.2.0 || ~8.3.0 || ~8.4.0",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

imo, I think it is time to remove php ~8.0.0 support, other components no longer have php ~8.0.0 :)

"ext-json": "*",
"laminas/laminas-http": "^2.15",
"laminas/laminas-stdlib": "^3.10.1"
},
"require-dev": {
"laminas/laminas-coding-standard": "~2.5.0",
"laminas/laminas-config": "^3.8",
"laminas/laminas-validator": "^2.29",
"phpunit/phpunit": "^9.5.27",
"laminas/laminas-config": "^3.9",
"laminas/laminas-validator": "^2.30.1",
"phpunit/phpunit": "^9.6.15",
"psalm/plugin-phpunit": "^0.18.4",
"vimeo/psalm": "^5.4"
"vimeo/psalm": "^5.19"
},
"conflict": {
"zendframework/zendservice-recaptcha": "*"
Expand Down
4 changes: 2 additions & 2 deletions composer.lock
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion docs/book/intro.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ if a user correctly provides the first word, the second is likely correctly ente
improve OCR software for digitizing books.

<!-- markdownlint-disable-next-line header-increment -->
manishranjan-adobe marked this conversation as resolved.
Show resolved Hide resolved
> ### Additional Requirements
> ## Additional Requirements
manishranjan-adobe marked this conversation as resolved.
Show resolved Hide resolved
>
> In order to use the reCAPTCHA service, you will need to
> [sign up for an account](https://www.google.com/recaptcha/admin) and register
Expand Down