-
-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added PHP 8.4 Support #39
base: 3.8.x
Are you sure you want to change the base?
Added PHP 8.4 Support #39
Conversation
Signed-off-by: manishranjan-adobe <[email protected]>
Signed-off-by: manishranjan-adobe <[email protected]>
Signed-off-by: manishranjan-adobe <[email protected]>
Signed-off-by: manishranjan-adobe <[email protected]>
@froschdesign Can you check this PR? All the checks have been passed. It would be great if you could take a moment to review it when you have the time. I’ve made sure to follow the contribution guidelines, but I’d appreciate any feedback or suggestions for improvement. Looking forward to your insights! |
Signed-off-by: manishranjan-adobe <[email protected]>
@gsteel Can we please pick this? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @manishranjan-adobe - Just one tweak to the markdown file
Signed-off-by: manishranjan-adobe <[email protected]>
Signed-off-by: manishranjan-adobe <[email protected]>
Signed-off-by: manishranjan-adobe <[email protected]>
@@ -16,18 +16,18 @@ | |||
"rss": "https://github.com/laminas/laminas-recaptcha/releases.atom" | |||
}, | |||
"require": { | |||
"php": "~8.0.0 || ~8.1.0 || ~8.2.0 || ~8.3.0", | |||
"php": "~8.0.0 || ~8.1.0 || ~8.2.0 || ~8.3.0 || ~8.4.0", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
imo, I think it is time to remove php ~8.0.0
support, other components no longer have php ~8.0.0
:)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Missing a new line at the end of the file.
Description
Tell us about why this change is necessary:
Added PHP 8.4 Support
Are you adding documentation?
Are you providing a QA improvement (additional tests, CS fixes, etc.) that
does not change behavior?
Are you fixing a BC Break?
Are you adding something the library currently does not support?
Are you refactoring code?