Added PHP 8.4 Support #39
Open
+9
−9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: manishranjan-adobe <[email protected]>
Signed-off-by: manishranjan-adobe <[email protected]>
Signed-off-by: manishranjan-adobe <[email protected]>
Signed-off-by: manishranjan-adobe <[email protected]>
|
@froschdesign Can you check this PR? All the checks have been passed. It would be great if you could take a moment to review it when you have the time. I’ve made sure to follow the contribution guidelines, but I’d appreciate any feedback or suggestions for improvement. Looking forward to your insights! |
Signed-off-by: manishranjan-adobe <[email protected]>
|
@gsteel Can we please pick this? |
gsteel
requested changes
Oct 22, 2024
There was a problem hiding this comment.
Thanks @manishranjan-adobe - Just one tweak to the markdown file
Signed-off-by: manishranjan-adobe <[email protected]>
Signed-off-by: manishranjan-adobe <[email protected]>
samsonasik
reviewed
Oct 23, 2024
Signed-off-by: manishranjan-adobe <[email protected]>
samsonasik
approved these changes
Oct 23, 2024
samsonasik
reviewed
Oct 23, 2024
| @@ -16,18 +16,18 @@ | |||
| "rss": "https://github.com/laminas/laminas-recaptcha/releases.atom" | |||
| }, | |||
| "require": { | |||
| "php": "~8.0.0 || ~8.1.0 || ~8.2.0 || ~8.3.0", | |||
| "php": "~8.0.0 || ~8.1.0 || ~8.2.0 || ~8.3.0 || ~8.4.0", | |||
There was a problem hiding this comment.
imo, I think it is time to remove php ~8.0.0 support, other components no longer have php ~8.0.0 :)
alexmerlin
reviewed
Oct 24, 2024
There was a problem hiding this comment.
Missing a new line at the end of the file.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Tell us about why this change is necessary:
Added PHP 8.4 Support
Are you adding documentation?
Are you providing a QA improvement (additional tests, CS fixes, etc.) that
does not change behavior?
Are you fixing a BC Break?
Are you adding something the library currently does not support?
Are you refactoring code?