Catch early-exit errors in Kaocha.repl #265
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #265 +/- ##
==========================================
- Coverage 75.91% 75.62% -0.29%
==========================================
Files 51 51
Lines 2649 2659 +10
Branches 246 246
==========================================
Hits 2011 2011
- Misses 485 495 +10
Partials 153 153
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
plexus
reviewed
Jan 12, 2022
| (catch :kaocha/early-exit {exit-code :kaocha/early-exit} | ||
| (if (not= exit-code 0) | ||
| (output/error "Test run exited with code " exit-code) | ||
| (output/warn "Test run exited with code " exit-code)) |
There was a problem hiding this comment.
do we ever :early-exit with code 0? Seems contradictory.
There was a problem hiding this comment.
Yeah, probably. We do if no tests are found (its own issue #211) and in the kaocha.plugin.alpha.info plugin.
|
Looks good! definitely an improvement! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #231 by adding a basic message instead of letting errors bubble up.
I found calling
kaocha.repl/runwith a fake test-id was an easy way to trigger an early-exit error.