Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

kaocha.repl/run and run-all should catch :kaocha/early-exit #231

Closed
plexus opened this issue Jul 9, 2021 · 2 comments
Closed

kaocha.repl/run and run-all should catch :kaocha/early-exit #231

plexus opened this issue Jul 9, 2021 · 2 comments
Labels
first issue only These tickets are only for first-time contributors.

Comments

@plexus
Copy link
Member

plexus commented Jul 9, 2021

When running through the REPL there is no handler for these exceptions, causing them to bubble up. These exceptions are internal and should never bubble out of end-user APIs.
@alysbrooks alysbrooks assigned alysbrooks and unassigned alysbrooks Sep 23, 2021
@alysbrooks alysbrooks added the first issue only These tickets are only for first-time contributors. label Sep 23, 2021
@alysbrooks
Copy link
Member

You can reproduce this error by passing a nonexistent test ID to kaocha.repl/run.

@alysbrooks alysbrooks mentioned this issue Jan 11, 2022
Merged
@alysbrooks
Copy link
Member

Fixed by #265.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
first issue only These tickets are only for first-time contributors.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@plexus @alysbrooks