Fix various for release 3.6.0 pre #1230
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
67%] Linking CXX executable servoSimuAfma6FourPoints2DCamVelocity
In file included from /home/fspindle/visp_ws/visp/modules/tracker/me/include/visp3/me/vpMeEllipse.h:46,
from /home/fspindle/visp_ws/visp/modules/visual_features/include/visp3/visual_features/vpFeatureBuilder.h:52,
from /home/fspindle/visp_ws/visp/example/robot-simulator/camera/servoSimuCircle2DCamVelocity.cpp:61:
/home/fspindle/visp_ws/visp/modules/tracker/me/include/visp3/me/vpMeTracker.h:99:16: warning: ‘virtual void vpMeTracker::display(const vpImage<vpRGBa>&)’ was hidden [-Woverloaded-virtual=]
99 | virtual void display(const vpImage<vpRGBa> &I);
| ^~~~~~~
/home/fspindle/visp_ws/visp/modules/tracker/me/include/visp3/me/vpMeEllipse.h:486:29: note: by ‘vpMeEllipse::display’
486 | vp_deprecated static void display(const vpImage<vpRGBa> &I, const vpImagePoint ¢er, const double &A, const double &B,
| ^~~~~~~
/home/fspindle/visp_ws/visp/modules/tracker/me/include/visp3/me/vpMeTracker.h:98:16: warning: ‘virtual void vpMeTracker::display(const vpImage<unsigned char>&)’ was hidden [-Woverloaded-virtual=]
98 | virtual void display(const vpImage<unsigned char> &I);
| ^~~~~~~
/home/fspindle/visp_ws/visp/modules/tracker/me/include/visp3/me/vpMeEllipse.h:486:29: note: by ‘vpMeEllipse::display’
486 | vp_deprecated static void display(const vpImage<vpRGBa> &I, const vpImagePoint ¢er, const double &A, const double &B,
| ^~~~~~~
/home/fspindle/visp_ws/visp/modules/tracker/me/include/visp3/me/vpMeTracker.h:99:16: warning: ‘virtual void vpMeTracker::display(const vpImage<vpRGBa>&)’ was hidden [-Woverloaded-virtual=]
99 | virtual void display(const vpImage<vpRGBa> &I);
| ^~~~~~~
In file included from /home/fspindle/visp_ws/visp/modules/visual_features/include/visp3/visual_features/vpFeatureBuilder.h:53:
/home/fspindle/visp_ws/visp/modules/tracker/me/include/visp3/me/vpMeLine.h:273:29: note: by ‘vpMeLine::display’
273 | vp_deprecated static void display(const vpImage<vpRGBa> &I, const vpMeSite &PExt1, const vpMeSite &PExt2,
| ^~~~~~~
/home/fspindle/visp_ws/visp/modules/tracker/me/include/visp3/me/vpMeTracker.h:98:16: warning: ‘virtual void vpMeTracker::display(const vpImage<unsigned char>&)’ was hidden [-Woverloaded-virtual=]
Pose estimated exceeds the threshold (t_thresh = 0.005 ; tu_thresh = 3.5)! t_err: 0.00273534 ; tu_err: 3.53661 Computation time, Mean: 36.8946 ms ; Median: 34.4281 ms ; Std: 10.2622 ms Max translation error: 0.00329194 Max thetau error: 3.53661 Test result: failure Thetau threshold increased to 3.7 Uses OpenCV 4.6.0
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## master #1230 +/- ##
==========================================
+ Coverage 54.34% 54.44% +0.09%
==========================================
Files 405 404 -1
Lines 49832 49831 -1
==========================================
+ Hits 27083 27129 +46
+ Misses 22749 22702 -47
☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contains some fixes detected when building on Debian sid