Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: NEO sider's toggle button and refactoring #2853

Open
wants to merge 1 commit into
base: feature/neo-sider
Choose a base branch
from

Conversation

yomybaby
Copy link
Member

@yomybaby yomybaby commented Nov 15, 2024

image.png

Changes:

  • Added keyboard shortcut '[' to toggle sidebar collapse state
  • Introduced a collapsible button on the sidebar that appears on hover
  • Moved sidebar footer content into a more structured layout
  • Added useKeyboardShortcut hook to handle keyboard shortcuts when no input is focused
  • Refactored BAISider component to use forwardRef and improve layout structure
  • Standardized sidebar width constants (COLLAPSED_SIDER_WIDTH = 74, SIDER_WIDTH = 240)
  • Removed bottomText prop from BAISider in favor of direct content rendering
  • Added hover detection for showing/hiding the collapse toggle button

Testing Requirements:

  1. Verify the '[' keyboard shortcut toggles sidebar when no input is focused
  2. Check that the collapse button appears on sidebar hover
  3. Confirm sidebar footer content displays correctly in both expanded/collapsed states
  4. Test that keyboard shortcuts don't trigger when inputs or modals are focused

Copy link

graphite-app bot commented Nov 15, 2024

Your org requires the Graphite merge queue for merging into main

Add the label “flow:merge-queue” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “flow:hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

Copy link
Member Author

yomybaby commented Nov 15, 2024

@yomybaby yomybaby force-pushed the feature/webui-neo-toggle-sider branch 2 times, most recently from b2825e2 to f7c1327 Compare November 15, 2024 07:34
@github-actions github-actions bot added size:XL 500~ LoC and removed size:L 100~500 LoC labels Nov 15, 2024
@yomybaby yomybaby marked this pull request as ready for review November 15, 2024 07:36
@yomybaby yomybaby force-pushed the feature/webui-neo-toggle-sider branch 2 times, most recently from 9f465cc to e79c472 Compare November 15, 2024 07:44
@yomybaby yomybaby force-pushed the feature/webui-neo-toggle-sider branch from e79c472 to e4c88ef Compare November 16, 2024 03:01
@yomybaby yomybaby force-pushed the feature/webui-neo-toggle-sider branch from e4c88ef to 7f136aa Compare November 16, 2024 03:29
@yomybaby yomybaby force-pushed the feature/webui-neo-toggle-sider branch from 7f136aa to eb4ea48 Compare November 17, 2024 00:20
@yomybaby yomybaby force-pushed the feature/webui-neo-toggle-sider branch 3 times, most recently from 930d3ba to 236b757 Compare November 18, 2024 02:27
@yomybaby yomybaby force-pushed the feature/webui-neo-toggle-sider branch 3 times, most recently from 5423dc8 to 8e397a2 Compare November 18, 2024 03:34
@yomybaby yomybaby linked an issue Nov 18, 2024 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size:XL 500~ LoC
Projects
None yet
Development

Successfully merging this pull request may close these issues.

MainLayout NEO: Sider
1 participant