Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Main layout NEO header #2844

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Conversation

yomybaby
Copy link
Member

@yomybaby yomybaby commented Nov 12, 2024

Resolves #2838

Neo Header

image.png

image.png

image.png

image

Changes:

  • Redesigned the WebUI header with a new orange theme and improved layout
  • Added ghost style select component for better visibility on colored backgrounds
  • Added reverse theme provider component to handle light/dark theme switching
  • Updated login session extension UI with a more compact design
  • Added classnames dependency for better CSS class handling
  • Updated translations for "Extend Login Session" across all languages

Key UI/UX Improvements:

  • Header now uses a distinct orange background color for better visual hierarchy
  • Project selector uses ghost style for better contrast on colored backgrounds
  • Login session timer shows condensed format on smaller screens
  • Notification and user menu buttons have consistent styling with the header theme

Technical Details:

  • Removed inline styles in favor of styled components
  • Added ReverseThemeProvider for proper light/dark theme handling in the header
  • Updated theme configuration with new color tokens and layout settings
  • Improved responsive behavior for mobile devices

Copy link

graphite-app bot commented Nov 12, 2024

Your org requires the Graphite merge queue for merging into main

Add the label “flow:merge-queue” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “flow:hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

Copy link
Member Author

yomybaby commented Nov 12, 2024

This stack of pull requests is managed by Graphite. Learn more about stacking.

@github-actions github-actions bot added area:ux UI / UX issue. area:i18n Localization size:L 100~500 LoC labels Nov 12, 2024
@github-actions github-actions bot added size:XL 500~ LoC and removed size:L 100~500 LoC labels Nov 13, 2024
Copy link

github-actions bot commented Nov 13, 2024

Coverage report for ./react

St.
Category Percentage Covered / Total
🔴 Statements
5.37% (-0.01% 🔻)
395/7356
🔴 Branches
4.66% (-0.01% 🔻)
237/5087
🔴 Functions
3.21% (-0.01% 🔻)
78/2429
🔴 Lines
5.28% (-0.01% 🔻)
380/7193
Show new covered files 🐣
St.
File Statements Branches Functions Lines
🔴
... / ReverseThemeProvider.tsx
0% 0% 0% 0%
Show files with reduced coverage 🔻
St.
File Statements Branches Functions Lines
🔴
... / BAINotificationButton.tsx
0%
0% (-100% 🔻)
0% 0%

Test suite run success

124 tests passing in 14 suites.

Report generated by 🧪jest coverage report action from 9fc59ae

@yomybaby yomybaby marked this pull request as ready for review November 13, 2024 02:19
Comment on lines +135 to +139
<BAINotificationButton
buttonRender={(btn) => (
<ReverseThemeProvider>{btn}</ReverseThemeProvider>
)}
/>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a reason you only added bottenRender to certain buttons?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ironAiken2 In the NEO UI, the header uses a reversed theme: white text in light mode and black text in dark mode. Therefore, we need to apply the reversed theme to the button only, excluding the Dropdown and Notification drawer.
With the buttonRender, we can wrap the button depending on the situation.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this different from wrapping it in a ReserveThemeProvider without a buttonRender?
<ReserveThemeProvider> <BAINotificationButton /> </ReserveThemeProvider

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:i18n Localization area:ux UI / UX issue. size:XL 500~ LoC
Projects
None yet
Development

Successfully merging this pull request may close these issues.

MainLayout NEO: Header
2 participants