UDPRoute Controller Scaffolding #36
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
shaneutt
previously approved these changes
Dec 6, 2022
There was a problem hiding this comment.
Thanks @rushi47!
While there's a couple of things we could still tweak here, there's a few other issues waiting on this one and this controller currently isn't actually fully implemented so this seems like a fine jumping off point and we can start on some follow-up iterations. 👍
Appreciate the contribution, good work! 🖖
Signed-off-by: rushi47 <[email protected]>
rushi47
force-pushed
the
udp_scaffolding_issue30
branch
from
9ef50c7 to
91de00e
Compare
* Package import structure * Comment refactoring Co-authored-by: Shane Utt <[email protected]> Signed-off-by: rushi47 <[email protected]>
Signed-off-by: rushi47 <[email protected]>
Signed-off-by: rushi47 <[email protected]>
Signed-off-by: rushi47 <[email protected]>
rushi47
force-pushed
the
udp_scaffolding_issue30
branch
from
91de00e to
94c1cbd
Compare
shaneutt
pushed a commit
to shaneutt/blixt
that referenced
this pull request
Oct 11, 2023
Signed-off-by: rushi47 <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem Statement
We need to add a controller to handle UDPRoutes. We'll start by adding the
basic scaffolding before we add the dataplane connection. This only includes
the basic scaffolding, not the data-plane configuration push yet that will be
handled in a follow-up.
TODO
controller added withoperator-sdk`UDPRouteis attached to aGatewaysupported byGatewayClassand print this out to logsResolves : #30