-
Notifications
You must be signed in to change notification settings - Fork 52
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
UDPRoute Controller Scaffolding (#36)
Signed-off-by: rushi47 <[email protected]>
- Loading branch information
Showing
9 changed files
with
259 additions
and
2 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,4 +1,5 @@ | ||
| ## Append samples you want in your CSV to this file as resources ## | ||
| resources: | ||
| - gateway.yaml | ||
| - udproute.yaml | ||
| #+kubebuilder:scaffold:manifestskustomizesamples |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,61 @@ | ||
| package controllers | ||
|
|
||
| import ( | ||
| "path/filepath" | ||
| "testing" | ||
|
|
||
| . "github.com/onsi/ginkgo/v2" | ||
| . "github.com/onsi/gomega" | ||
|
|
||
| "k8s.io/client-go/kubernetes/scheme" | ||
| "k8s.io/client-go/rest" | ||
| "sigs.k8s.io/controller-runtime/pkg/client" | ||
| "sigs.k8s.io/controller-runtime/pkg/envtest" | ||
|
|
||
| // "sigs.k8s.io/controller-runtime/pkg/envtest/printer" | ||
| logf "sigs.k8s.io/controller-runtime/pkg/log" | ||
| "sigs.k8s.io/controller-runtime/pkg/log/zap" | ||
| //+kubebuilder:scaffold:imports | ||
| ) | ||
|
|
||
| // These tests use Ginkgo (BDD-style Go testing framework). Refer to | ||
| // http://onsi.github.io/ginkgo/ to learn more about Ginkgo. | ||
|
|
||
| var cfg *rest.Config | ||
| var k8sClient client.Client | ||
| var testEnv *envtest.Environment | ||
|
|
||
| func TestAPIs(t *testing.T) { | ||
| RegisterFailHandler(Fail) | ||
|
|
||
| RunSpecs(t, "Controller Suite") | ||
| } | ||
|
|
||
| var _ = BeforeSuite(func() { | ||
| logf.SetLogger(zap.New(zap.WriteTo(GinkgoWriter), zap.UseDevMode(true))) | ||
|
|
||
| By("bootstrapping test environment") | ||
| testEnv = &envtest.Environment{ | ||
| CRDDirectoryPaths: []string{filepath.Join("..", "config", "crd", "bases")}, | ||
| ErrorIfCRDPathMissing: false, | ||
| } | ||
|
|
||
| var err error | ||
| // cfg is defined in this file globally. | ||
| cfg, err = testEnv.Start() | ||
| Expect(err).NotTo(HaveOccurred()) | ||
| Expect(cfg).NotTo(BeNil()) | ||
|
|
||
| //+kubebuilder:scaffold:scheme | ||
|
|
||
| k8sClient, err = client.New(cfg, client.Options{Scheme: scheme.Scheme}) | ||
| Expect(err).NotTo(HaveOccurred()) | ||
| Expect(k8sClient).NotTo(BeNil()) | ||
|
|
||
| }) | ||
|
|
||
| var _ = AfterSuite(func() { | ||
| By("tearing down the test environment") | ||
| err := testEnv.Stop() | ||
| Expect(err).NotTo(HaveOccurred()) | ||
| }) |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,127 @@ | ||
| package controllers | ||
|
|
||
| import ( | ||
| "context" | ||
| "fmt" | ||
|
|
||
| "k8s.io/apimachinery/pkg/api/errors" | ||
| "k8s.io/apimachinery/pkg/runtime" | ||
| "k8s.io/apimachinery/pkg/types" | ||
| ctrl "sigs.k8s.io/controller-runtime" | ||
| "sigs.k8s.io/controller-runtime/pkg/client" | ||
| "sigs.k8s.io/controller-runtime/pkg/log" | ||
| gatewayv1alpha2 "sigs.k8s.io/gateway-api/apis/v1alpha2" | ||
| gatewayv1beta1 "sigs.k8s.io/gateway-api/apis/v1beta1" | ||
|
|
||
| "github.com/kong/blixt/pkg/vars" | ||
| ) | ||
|
|
||
| // UDPRouteReconciler reconciles a UDPRoute object | ||
| type UDPRouteReconciler struct { | ||
| client.Client | ||
| Scheme *runtime.Scheme | ||
| } | ||
|
|
||
| // Verify respective gateway has at least one listener matching to what is specified in UDPRoute parentRefs. | ||
| func (r *UDPRouteReconciler) verifyListener(ctx context.Context, gw *gatewayv1beta1.Gateway, udprouteSpec gatewayv1alpha2.ParentReference) error { | ||
| for _, listener := range gw.Spec.Listeners { | ||
| if (listener.Protocol == gatewayv1beta1.UDPProtocolType) && (listener.Port == gatewayv1beta1.PortNumber(*udprouteSpec.Port)) { | ||
| return nil | ||
| } | ||
| } | ||
| return fmt.Errorf("No matching Gateway listener found for defined Parentref") | ||
| } | ||
|
|
||
| // Verify if UDPRoute is managed by our implementation. | ||
| func (r *UDPRouteReconciler) isUDPRouteManaged(ctx context.Context, udproute gatewayv1alpha2.UDPRoute) (bool, *gatewayv1beta1.Gateway, error) { | ||
| log := log.FromContext(ctx) | ||
|
|
||
| var supportedGateways []gatewayv1beta1.Gateway | ||
|
|
||
| //Use the retrieve objects its parent ref to look for the gateway. | ||
| for _, parentRef := range udproute.Spec.ParentRefs { | ||
|
|
||
| //Build Gateway object to retrieve | ||
| gw := new(gatewayv1beta1.Gateway) | ||
|
|
||
| ns := udproute.Namespace | ||
| if parentRef.Namespace != nil { | ||
| ns = string(*parentRef.Namespace) | ||
| } | ||
|
|
||
| //Get Gateway for UDP Route | ||
| if err := r.Get(ctx, types.NamespacedName{Name: string(parentRef.Name), Namespace: ns}, gw); err != nil { | ||
| log.Info("Unable to get parent ref gateway for", "udpRoute", parentRef.Name, "Namespace", ns, "err", err) | ||
| //Check next parent ref. | ||
| continue | ||
| } | ||
|
|
||
| //Get GatewayClass for the Gateway and match to our name of controler | ||
| gwc := new(gatewayv1beta1.GatewayClass) | ||
| if err := r.Get(ctx, types.NamespacedName{Name: string(gw.Spec.GatewayClassName), Namespace: ns}, gwc); err != nil { | ||
| log.Info("Unable to get Gatewayclass", "Gateway", gw.Name, "Udp Route", parentRef.Name, "err", err) | ||
| //Check next parent ref. | ||
| continue | ||
| } | ||
|
|
||
| if gwc.Spec.ControllerName != vars.GatewayClassControllerName { | ||
| //Check next parent ref. | ||
| continue | ||
| } | ||
|
|
||
| //Check if referred gateway has the at least one listener with properties defined from UDPRoute parentref. | ||
| if err := r.verifyListener(ctx, gw, parentRef); err != nil { | ||
| log.Info("No matching listener found for referred gateway", "GatewayName", parentRef.Name, "GatewayPort", parentRef.Port) | ||
| //Check next parent ref. | ||
| continue | ||
| } | ||
|
|
||
| //TODO : Support for multiple Gateways : https://github.com/Kong/blixt/issues/40 | ||
| if len(supportedGateways) == 1 { | ||
| err := fmt.Errorf("Not implemented support, for more than one reffered Gateway.") | ||
| return false, &gatewayv1beta1.Gateway{}, err | ||
| } | ||
|
|
||
| supportedGateways = append(supportedGateways, *gw) | ||
| } | ||
|
|
||
| //only used for logging | ||
| refferedGateway := &supportedGateways[0] | ||
| log.Info("UDP Route appeared referring to Gateway", "Gateway ", refferedGateway.Name, "GatewayClass Name", refferedGateway.Spec.GatewayClassName) | ||
|
|
||
| return true, refferedGateway, nil | ||
| } | ||
|
|
||
| //+kubebuilder:rbac:groups=gateway.konghq.com,resources=udproutes,verbs=get;list;watch;create;update;patch;delete | ||
| //+kubebuilder:rbac:groups=gateway.konghq.com,resources=udproutes/status,verbs=get;update;patch | ||
| //+kubebuilder:rbac:groups=gateway.konghq.com,resources=udproutes/finalizers,verbs=update | ||
|
|
||
| // UDProuteReconciler reconciles UDPRoute object | ||
| func (r *UDPRouteReconciler) Reconcile(ctx context.Context, req ctrl.Request) (ctrl.Result, error) { | ||
| log := log.FromContext(ctx) | ||
|
|
||
| //Retrieve udp route object. | ||
| udproute := new(gatewayv1alpha2.UDPRoute) | ||
| if err := r.Get(ctx, req.NamespacedName, udproute); err != nil { | ||
| if errors.IsNotFound(err) { | ||
| log.Info("object enqueued no longer exists, skipping") | ||
| return ctrl.Result{}, nil | ||
| } | ||
| log.Info("Error retrieving udp route", "Err : ", err) | ||
| return ctrl.Result{}, err | ||
| } | ||
|
|
||
| isManaged, _, err := r.isUDPRouteManaged(ctx, *udproute) | ||
| if !isManaged { | ||
| return ctrl.Result{}, err | ||
| } | ||
| return ctrl.Result{}, nil | ||
| } | ||
|
|
||
| // SetupWithManager sets up the controller with the Manager. | ||
| func (r *UDPRouteReconciler) SetupWithManager(mgr ctrl.Manager) error { | ||
| return ctrl.NewControllerManagedBy(mgr). | ||
| // Uncomment the following line adding a pointer to an instance of the controlled resource as an argument | ||
| For(&gatewayv1alpha2.UDPRoute{}). | ||
| Complete(r) | ||
| } |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.