Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Adding @HumairAK to backend and frontend reviewers #11043

Merged
merged 2 commits into from
Jul 25, 2024

Conversation

chensun
Copy link
Member

@chensun chensun commented Jul 25, 2024

Description of your changes:
also cleanup inactive owners

Checklist:

Signed-off-by: Chen Sun <[email protected]>
Signed-off-by: Chen Sun <[email protected]>
Copy link

@chensun: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
kubeflow-pipeline-upgrade-test bfef49e link false /test kubeflow-pipeline-upgrade-test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Copy link
Member

@terrytangyuan terrytangyuan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

/lgtm

@jlyaoyuli
Copy link
Contributor

/lgtm
/approve

@chensun
Copy link
Member Author

chensun commented Jul 25, 2024

/approve

Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: chensun, jlyaoyuli, terrytangyuan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@google-oss-prow google-oss-prow bot merged commit f6ea7e3 into master Jul 25, 2024
12 of 13 checks passed
@google-oss-prow google-oss-prow bot deleted the chensun-patch-9 branch July 25, 2024 22:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants