Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add kfp backend/frontend reviewer #10962

Closed
wants to merge 1 commit into from

Conversation

HumairAK
Copy link
Collaborator

@HumairAK HumairAK commented Jun 26, 2024

I would like to throw my hat in for becoming a reviewer for the backend/frontend components. I have contributions and reviews in both these areas, and a fairly solid understanding on each component. Some examples:

  • Pull Requests: link
  • Reviews/Discussions: [1], [2]

I'm also fairly active in the KFP community calls.

In general, I think we need more reviewers in these areas to lessen the burden on the maintainers and help escalate the PR review process.

Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign jlyaoyuli, rimolive for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@HumairAK
Copy link
Collaborator Author

cc @chensun / @zijianjoy

Copy link

@HumairAK: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
kubeflow-pipeline-upgrade-test cc3ad03 link false /test kubeflow-pipeline-upgrade-test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@rimolive
Copy link
Member

/lgtm

Thanks for stepping up in this!

Also, cc @james-jwu

@HumairAK
Copy link
Collaborator Author

bump, fyi @chensun

@HumairAK
Copy link
Collaborator Author

closing in favor of: #11043

@HumairAK HumairAK closed this Jul 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants