-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(ws): Notebooks 2.0 // Backend // List Workspaces API II #61
Conversation
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@thesuperzapper the FUP from your last code review! |
In this PR: - FUP for Notebooks 2.0 // Backend // List Workspaces API (kubeflow#60) review - Create /api/v1/workspaces to return all workspaces - Review API endpoints as requested Signed-off-by: Eder Ignatowicz <[email protected]>
This PR builds on top of: kubeflow#61 and kubeflow#65 In this PR: - Created handlers and repositories for get workspacekinds This PR closes kubeflow#51 Signed-off-by: Eder Ignatowicz <[email protected]>
In this PR: - Created handlers and repositories for get workspacekinds This PR closes kubeflow#51 Signed-off-by: Eder Ignatowicz <[email protected]>
In this PR: - Created handlers and repositories for get workspacekinds This PR closes kubeflow#51 Signed-off-by: Eder Ignatowicz <[email protected]>
This PR builds on top of: kubeflow#61 and kubeflow#65 In this PR: - Created handlers and repositories for get workspacekinds This PR closes kubeflow#51 Signed-off-by: Eder Ignatowicz <[email protected]>
* feat(ws): Notebooks 2.0 // Backend // List Workspaces API - II In this PR: - FUP for Notebooks 2.0 // Backend // List Workspaces API (#60) review - Create /api/v1/workspaces to return all workspaces - Review API endpoints as requested Signed-off-by: Eder Ignatowicz <[email protected]> * Notebooks 2.0 // Backend // CRUD Workspaces API In this PR: - Created handlers and repositories for create, get and delete workspace - Improved the type of our json response Signed-off-by: Eder Ignatowicz <[email protected]> * feat(ws): Notebooks 2.0 // Backend // List WorkspaceKinds This PR builds on top of: #61 and #65 In this PR: - Created handlers and repositories for get workspacekinds This PR closes #51 Signed-off-by: Eder Ignatowicz <[email protected]> * mathew: fix linting Signed-off-by: Mathew Wicks <[email protected]> --------- Signed-off-by: Eder Ignatowicz <[email protected]> Signed-off-by: Mathew Wicks <[email protected]> Co-authored-by: Mathew Wicks <[email protected]>
In this PR: