feat(ws): add CRUD operations to backend #66
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In this PR: - FUP for Notebooks 2.0 // Backend // List Workspaces API (kubeflow#60) review - Create /api/v1/workspaces to return all workspaces - Review API endpoints as requested Signed-off-by: Eder Ignatowicz <[email protected]>
In this PR: - Created handlers and repositories for create, get and delete workspace - Improved the type of our json response Signed-off-by: Eder Ignatowicz <[email protected]>
This PR builds on top of: kubeflow#61 and kubeflow#65 In this PR: - Created handlers and repositories for get workspacekinds This PR closes kubeflow#51 Signed-off-by: Eder Ignatowicz <[email protected]>
Signed-off-by: Mathew Wicks <[email protected]>
thesuperzapper
changed the title
thesuperzapper
changed the title
thesuperzapper
changed the title
|
@ederign we can follow up with more PRs, and to implement the things we discussed in the meeting (changes to the JSON response structures and rejecting bad requests). /lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: thesuperzapper The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR builds on top of #61 and #65:
In this PR:
There is still more to do for #49