Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make ToolbarWindow toggleable via command #87

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

Fayti1703
Copy link
Member

@Fayti1703 Fayti1703 commented Dec 17, 2022

Baseline change as it says on the tin.

I've adjusted the GPose event listener to use bool while I was at it. If you want this as a separate PR (or merge just those early), tell me.

Open Issues:

  • These changes are untested
  • If the toolbar sub-command is executed outside of GPose, nothing currently happens. Unsure if we should just allow the toolbar window up regardless or display a warning to the user somehow. (I'd prefer the latter, but I don't know how to do that with Dalamud)

@Fayti1703 Fayti1703 force-pushed the proposals/fayti1703/toolbar-cmd branch 2 times, most recently from d6e19a4 to 7a3595e Compare December 18, 2022 10:27
@chirpxiv
Copy link
Member

Exception when entering GPose:

17:04:35.520 | ERR Exception during raise of "Void Draw()"
System.NullReferenceException: Object reference not set to an instance of an object.
   at Ktisis.Interface.Components.Toolbar.ToolbarActorsList.IsValidActor(Int64 target) in D:\Projects\ktisis\Ktisis\Ktisis\Interface\Components\Toolbar\ToolbarActorsList.cs:line 107
   at Ktisis.Interface.Components.Toolbar.ToolbarActorsList.<>c.<Draw>b__4_0(Int64 o) in D:\Projects\ktisis\Ktisis\Ktisis\Interface\Components\Toolbar\ToolbarActorsList.cs:line 32
   at System.Collections.Generic.List`1.RemoveAll(Predicate`1 match)
   at Ktisis.Interface.Components.Toolbar.ToolbarActorsList.Draw() in D:\Projects\ktisis\Ktisis\Ktisis\Interface\Components\Toolbar\ToolbarActorsList.cs:line 32
   at Ktisis.Interface.Windows.Toolbar.ToolbarWindow.Draw() in D:\Projects\ktisis\Ktisis\Ktisis\Interface\Windows\Toolbar\ToolbarWindow.cs:line 90
   at Ktisis.Interface.KtisisGui.Draw() in D:\Projects\ktisis\Ktisis\Ktisis\Interface\KtisisGui.cs:line 36
   at Dalamud.Utility.EventHandlerExtensions.HandleInvoke(Action act) in C:\goatsoft\companysecrets\dalamud\Utility\EventHandlerExtensions.cs:line 96
{ } [ Send ]

@Fayti1703
Copy link
Member Author

That looks... unrelated? ToolbarActorsList is not touched by this PR at all. Only way I can explain that happening is if SavedObjects somehow got a null element in it, but that should happen without these changes too.

@Fayti1703
Copy link
Member Author

Note to self: c36a46a / 77ff104 (that is, the ActorStateWatcher refactoring commits) have landed as 639a896 / 306474b on v0.3/ui-rework.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants