Time and weather implementation #96
Conversation
|
Relations:
(This is for internal tracking. Conflicts need not be resolved prior to merging.) |
|
Fixes are up, and I do intend to push the changes back to ClientStructs so we can drop ExtendedFramework once that makes it back upstream. |
|
Update for 6.3 |
|
It looks like you merged your old and new histories rather than force-pushing, which is making the commit history look a bit wierd. |
|
Should be resolved |
|
Yes, as per my twitter and posts on discord, I am taking a break from the FFXIV dev community and won't be actively contributing to any projects at present. The code is still there in the PR if you want to use it, I just won't be shepherding it through the process. I'm happy to discuss it privately if you have any questions, a GitHub issue is not the right forum. |
|
Okay. These can stay open though, we'll make any adjustments as needed. |
Side note regarding this - I'd prefer that any communication regarding Ktisis stays public for the sake of transparency, for users, contributors, and the rest of the team. If you don't want to discuss it in a GitHub issue, then the Discord has the #ktisis-dev channel for that. |
In the interests of transparency then. The very serious accusations of copying and theft, as well as the vile abuse I've received in DMs on both Discord and Twitter have been from people claiming or implying they are acting on behalf of the Ktisis dev team, without being willing to use anything more than a socketpuppet account and immediately lock down the account or delete the tweets/account in question. Regardless, it's clear that this has turned into some perverse, childish, toxic competition between Ktisis/Brio/Anamnesis and if that's going to be the case, I don't want to be involved in posing development for the foreseeable future. I did this for the fun of it and in pursuit of knowledge that would benefit all 3 projects, and to be attacked, called homophobic names and abused is not my idea of fun. |
|
I'm really sorry to hear that. I completely understand you wanting to take a break if that's what you've had to deal with. We were genuinely unaware of any harassment. We did not and do not direct others to abuse you or other developers; nor did or will we use alt accounts to hurt other people. Speaking for myself, I realize I may come off as harsh or abrasive while critiquing something on a technical level, but that is not meant as a personal attack in any way. Regardless, we respect your decision and wish you the best. |
I'm glad to hear that, and I believed it to be the case, but the confirmation is a comfort.
I have no problems with anything you've said to me personally or our interactions, discussion of code quality is healthy and normal.
I wish you the best as well, perhaps in the future when things have calmed down, we'll be able to collab again. |
Implements time and weather changing.
WorldHooksin this case is actually doing a bit more than hooking and the general vars it exposes might be better suited to some other more generic 'Service' but there doesn't seem to be a model for that in Ktisis currently, unless I missed it.Also not crazy about how it's grabbing the territory/weather info from Lumina (The animation stuff has a similar issue), so that's another area where an official way to do that kind of work might be nice in future.