-
Notifications
You must be signed in to change notification settings - Fork 297
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Laravel 11.x Compatibility #721
Laravel 11.x Compatibility #721
Conversation
⚗️ Using this package? If you would like to help test these changes or believe them to be compatible, you may update your project to reference this branch. To do so, temporarily add Shift's fork to the {
"repositories": [
{
"type": "vcs",
"url": "https://github.com/laravel-shift/laravel-form-builder.git"
}
]
} Then update your dependency constraint to reference this branch: {
"require": {
"kris/laravel-form-builder": "dev-l11-compatibility",
}
} Finally, run: |
Tests pass, buttttt with Laravel 10, not 11. Maybe the test should have a version matrix for PHP + Laravel, so we can explicitly test L9, L10 and L11. |
I need this module for Laravel v11. I tried to install the module with the above guide, but I've got error. When will this module be ready to work in laravel v11? |
We need betters tests in .github/workflows/test.yml. Laravel 11 isn't tested now. We need a better matrix that tests |
The test matrix works, butttt all Laravel 11 tests fail. @webpioneer23 How do you feel about finding out why and fix them? :D Check out this branch, and then run |
I check it, if you change composer like this:
all of your test with laravel 11 will pass. The issue is for PHP unite 11, if want to use PHP unite 11 you should change tests and remove all @test annotation and use test in function name with camelcase . see: |
@hooman-mirghasemi Almost perfect. All we have to do now is tell the Github workflow to use phpunit 9.x for Laravel 9. More |
Laravel 11 seems to work fine. And Github tests too 👍 Thanks @hooman-mirghasemi |
your welcome |
Voila 1.53 |
This is an automated pull request from Shift to update your package code and dependencies to be compatible with Laravel 11.x.
Before merging, you need to:
l11-compatibility
branchIf you do find an issue, please report it by commenting on this PR to help improve future automation.