Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for Laravel 11 #723

Closed
michaelLoeffelmann opened this issue Mar 22, 2024 · 4 comments · Fixed by #721
Closed

Support for Laravel 11 #723

michaelLoeffelmann opened this issue Mar 22, 2024 · 4 comments · Fixed by #721

Comments

@michaelLoeffelmann
Copy link

Are there plans for Laravel 11 support?

@rudiedirkx
Copy link
Collaborator

#721 but it needs some work. I could merge without working tests, buttt I don't know if it actually works in L11. If you know how phpunit works, you could fix the tests. With 1 codebase for all versions plz.

@rudiedirkx rudiedirkx linked a pull request Mar 26, 2024 that will close this issue
@noge075
Copy link

noge075 commented Apr 20, 2024

So what is the final conclusion about this? We should use the fork or do you have plans to continue? Thanks for your work!

@rudiedirkx
Copy link
Collaborator

Someone has to test the Laravel 11 branch. It'd be nice if someone fixed the tests, so Github can test automatically, but nobody seems willing/able. So someone has to test it for real. You can temprarily add it from Github locally, like @laravel-shift said in #721 (comment)

@hooman-mirghasemi
Copy link

hooman-mirghasemi commented Apr 20, 2024

@rudiedirkx
check my comment

for running test for laravel 11

@rudiedirkx rudiedirkx pinned this issue Apr 21, 2024
@rudiedirkx rudiedirkx unpinned this issue Apr 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants