Add a flightradar24 client. #123
Conversation
shinysdr/devices.py
Outdated
| @@ -138,6 +138,12 @@ def close(): | |||
| __all__.append('IComponent') | |||
|
|
|||
|
|
|||
| class ITopWatcher(Interface): | |||
There was a problem hiding this comment.
This is not a good plan. Top is not a well-designed interface, and is going to go away in its current form when the multi-session refactoring finally happens.
Since I want this to happen anyway, I'll see if I can implement a better approach for hooking up telemetry.
| self.__top = top | ||
|
|
||
| def __make_url(self): | ||
| u = URL.fromText('https://data-live.flightradar24.com/zones/fcgi/feed.js?faa=1&mlat=1&flarm=1&adsb=1&gnd=0&air=1&vehicles=0&estimated=1&maxage=14400&gliders=1&stats=0') |
There was a problem hiding this comment.
Make this a parameter passed in from the Flightradar24 function so that it can be replaced with a local stub for testing, or if the user wants to change some parameters.
There was a problem hiding this comment.
Oops, I keep forgetting to push 'Start a review' on GitHub. Sorry for the disorganized comments.
I like this feature addition! There's already a half-baked one that is structurally similar — APRSISRXDevice in the APRS plugin. It has the same problem with accessing the telemetry store that you had, so a solution should be applied to it too.
|
|
||
|
|
||
| @implementer(IAircraft, ITelemetryObject) | ||
| class Aircraft(ExportedState): |
There was a problem hiding this comment.
This should share an Aircraft telemetry object type with the Mode S plugin so that information from both sources can be combined and not duplicated (and we don't need to duplicate the map layer code too).
There's already a multi-plugin situation in APRS — there, there is a plugin for core APRS functionality and a plugin for the multimon-ng decoder. Here, I'd suggest for now depending on the one in the Mode S plugin. If you need to make any changes to it, add comments there that it's used in two places.
The logic to decode the two kinds of messages can go in the message objects.
There was a problem hiding this comment.
I'm not sure I agree it should share the same Aircraft layer as the Mode S plugin. Ideally I would like Flightradar24 to be its own map layer, and to have the enable/disable checkbox on the layer actually toggle the enablement of the event loop here.
There was a problem hiding this comment.
Separate layers can be handled by adding something like a "from what data sources" field to the objects and having the layer provide subordinate filtering options (much like the database layer lets you enter search text). That gets you the functionality without duplicating code and preventing data merging.
(Now that I've thought of it, it seems reasonable to have 'data sources for this object' be a general feature of the telemetry system; e.g. someone might want to filter APRS the same way.)
| _FEET_PER_MINUTE_TO_METERS_PER_SECOND = _METERS_PER_FEET * 60 | ||
|
|
||
|
|
||
| # TODO: This really shouldn't be a Device, but that's the only way right now to hook into the config. |
There was a problem hiding this comment.
Actually, being a Device is fine and correct, since it connects to something in the outside world and receives information. Rather, we should improve support for non-RF devices. (Delete this comment.)
This renders aircraft from flightradar24 much like the mode_s plugin.
This dramatically improves performance of the map with many aircraft by reducing the number of cells per aircraft.
quentinmit
force-pushed
the
flightradar24
branch
from
9a19982
to
6da8b77
Compare
shinysdr/devices.py
Outdated
| @@ -138,6 +138,12 @@ def close(): | |||
| __all__.append('IComponent') | |||
|
|
|||
|
|
|||
| class ITopWatcher(Interface): | |||
| _FEET_PER_MINUTE_TO_METERS_PER_SECOND = _METERS_PER_FEET * 60 | ||
|
|
||
|
|
||
| # TODO: This really shouldn't be a Device, but that's the only way right now to hook into the config. |
|
|
||
|
|
||
| @implementer(IAircraft, ITelemetryObject) | ||
| class Aircraft(ExportedState): |
There was a problem hiding this comment.
I'm not sure I agree it should share the same Aircraft layer as the Mode S plugin. Ideally I would like Flightradar24 to be its own map layer, and to have the enable/disable checkbox on the layer actually toggle the enablement of the event loop here.
| self.__top = top | ||
|
|
||
| def __make_url(self): | ||
| u = URL.fromText('https://data-live.flightradar24.com/zones/fcgi/feed.js?faa=1&mlat=1&flarm=1&adsb=1&gnd=0&air=1&vehicles=0&estimated=1&maxage=14400&gliders=1&stats=0') |
This allows flightradar24 to be a telemetry source. There wasn't any way to get access to the TelemetryStore for things other than IDemodulators, so I had to add a hook for device components to get access. PTAL and feel free to suggest a better way to hook it in.