Master release 4.3.00 #2163
Merged
Master release 4.3.00 #2163
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Just reflecting the move of HIP and HIPSpace out of experimental so that we do not get deprecation warning and even failures down the road. This was really done in Kokkos Core 4.0.0 so it is time to catch up...
par_ilut: Update documentation for fill_in_limit
bhalf_t fix for isnan function
Experimental hip cleanup
cm_test_all_sandia: allow rocm/5.2.0 for caraway vega90A builds
The issue is fixed by disabling the TPL in spec_avail when a problematic version of CUDA/cuSPARSE is being used.
Just inverted the logic statement to enable the TPL when it is known to work correctly.
In KokkosBlas1_axpby_unification_attempt.hpp:
- Removed unnecessary variables, routines, and checks
- Imposed terminology consistency: variable names begin with lower case letters, type names begin with upper case letters
- Using static_assert as much as possible
- Using 'public' and 'private' keywords accordingly
- Improved some explanations and error messages
In KokkosBlas1_axpby_spec.hpp:
- Replace 'a' and 'b' by 'scalar_x' and 'scalar_y' where appropriate, to keep consistency with the terminology used in the 'impl' and 'mv_impl' files of the axpby operation.
- Not using the 'KOKKOSBLAS_OPTIMIZATION_LEVEL_AXPBY' define anymore. Code is now consistent with the 'old' value 3 for such define.
In KokkosBlas1_axpby_impl.hpp and KokkosBlas1_axpby_mv_impl.hpp:
- Not using the 'KOKKOSBLAS_OPTIMIZATION_LEVEL_AXPBY' define anymore. Code is now consistent with the 'old' value 3 for such define.
- Using 'if constexpr' whenever possible
- Checking that -1 <= scalar_x <= 2 and that -1 <= scalar_y <= 2
- Replaced '} else {' by '} else if (scalar_x == 2)' or by '} else if (scalar_y == 2)', whenever possible
- Improved error messages
- Improved explanation headers a bit
In KokkosBlas1_axpby.hpp:
- Renamed some variables to more meaningful names
On KokkosEco_Trilinos_Weaver_CUDA112_opt-uvm the SYR2 test enerates a compile time error probably due to a mixed use of host and device views when comparing implemented vs. reference results.
Bspgemm cusparse hang
Axpby: improvement on unification attempt logic and on the execution of a diversity of situations
…ards-2 CUDA 11.0.1 / cuSPARSE 11.0.0 changed SpMM enums
Resolve compilation errors in debug mode: "error: no member named 'cout' in namespace 'std';"
KokkosBlas1_axpby: include <iostream> for debug builds
KokkosKernels Utils: cleaning the zero_vector interface (cherry picked from commit 363868e)
…okkos#2157) * KokkosBlas1_axpby.hpp: change debug macro guard for printInformation - resolves test failures in Trilinos (MueLu) that rely on gold file diff comparisons by removing extra output in debug builds * fix compilation error
* Update changelog for 4.3.00 * Update CHANGELOG.md --------- Co-authored-by: Luc Berger <[email protected]>
Part of Kokkos C++ Performance Portability Programming EcoSystem 4.3
|
Trilinos snapshot PR: trilinos/Trilinos#12879 |
brian-kelley
reviewed
Apr 2, 2024
brian-kelley
approved these changes
Apr 2, 2024
|
I'm going to force push some changes, the merge resulted in an artifact that showed up with the Trilinos |
ndellingwood
force-pushed
the
master-release-4.3.00
branch
from
732fcb2 to
97adc61
Compare
This was referenced Apr 2, 2024
Updates from feedback runnig Trilinos testing (cherry picked from commit cacba80)
ndellingwood
force-pushed
the
master-release-4.3.00
branch
from
97adc61 to
d8e2b21
Compare
|
DOCS GA failure due to prohibited testing of release (4.3.00) against kokkos' develop branch (4.3.99), which is outside range of versions supported by the 4.3.0 release |
lucbv
approved these changes
Apr 4, 2024
|
changelog update PR to develop is up: #2169 |
|
Trilinos snapshot PR trilinos/Trilinos#12879 passed CI |
…abled Resolves redefintion of struct SVD compilation errors with both MKL and LAPACK are enabled Reported by @maartenarnst in trilinos/Trilinos#12891 Co-authored-by: brian-kelley <[email protected]> (cherry picked from commit 5bf5474)
|
Fixup #2171 cherry-picked, and snapshot of this updated branch made to Trilinos trilinos/Trilinos#12892 with the fix |
|
This should be ready for merge and tagging :) |
|
Okay, let's get this merged then |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.