Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Update act Dependency to v0.2.61 for Node 20 Actions Support #79

Merged
merged 1 commit into from
Apr 23, 2024
Merged

fix: Update act Dependency to v0.2.61 for Node 20 Actions Support #79

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@
"nektos/act"
],
"scripts": {
"postinstall": "node scripts/postinstall.js 0.2.48",
"postinstall": "node scripts/postinstall.js 0.2.61",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Ga13Ou does the postinstall actually affect users? Not only the CI / local development of act-js?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes since the postinstall script automatically runs after the npm install... , it means that for users who don't manually/separately install act and use the ACT_BINARYenv variable to point to their version, they will be automatically using the version specified in the postinstall script

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Correct. I had added it to fix #23

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, I see. We haven't faced this because we have always explicitly used the ACT_BINARY so that we control the exact version.

"build": "tsc && tsc-alias",
"pretest:it": "npm run postinstall && mkdir -p bin && cp build/bin/* bin/",
"test": "npm run test:unit && npm run test:it",
Expand Down
Loading