fix: Update act Dependency to v0.2.61 for Node 20 Actions Support #79
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shubhbapna
approved these changes
Apr 23, 2024
shubhbapna
changed the title
TWiStErRob
reviewed
Apr 24, 2024
| @@ -26,7 +26,7 @@ | |||
| "nektos/act" | |||
| ], | |||
| "scripts": { | |||
| "postinstall": "node scripts/postinstall.js 0.2.48", | |||
| "postinstall": "node scripts/postinstall.js 0.2.61", | |||
There was a problem hiding this comment.
@Ga13Ou does the postinstall actually affect users? Not only the CI / local development of act-js?
There was a problem hiding this comment.
Yes since the postinstall script automatically runs after the npm install... , it means that for users who don't manually/separately install act and use the ACT_BINARYenv variable to point to their version, they will be automatically using the version specified in the postinstall script
There was a problem hiding this comment.
Correct. I had added it to fix #23
There was a problem hiding this comment.
Ah, I see. We haven't faced this because we have always explicitly used the ACT_BINARY so that we control the exact version.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
This pull request updates the
actdependency inact-jsfrom v0.2.48 to v0.2.61. This update is crucial as it introduces support for Node 20, enablingact-jsto handle workflows that utilize the latest versions of GitHub Actions requiring Node 20.Why is this change necessary?
The current default version of
actused byact-js(v0.2.48) does not support Node 20, leading to failures when users attempt to execute workflows that depend on this Node version. By updating toactv0.2.61, we ensure compatibility with workflows having actions designed for Node 20, improving the tool's usability and reliability.Related issues