Fix checkup inconsistencies #42
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
arnongilboa
commented
Dec 19, 2024
arnongilboa
commented
- Skip checks when no default storage class - the PVC bound and VM checks cannot be executed without default storage class or default virt storage class, so skip them. Also added virt storage class support which was somehow missing.
- Prefer boot sources (official DataImportCrons and OS images) from the OpenShift Virtulization OS images namespace over other namespaces where users may have created test boot sources.
- Do not check PVC existence if VM DV source is snapshot.
The PVC bound and VM checks cannot be executed without default storage class or default virt storage class, so skip them. Added virt storage class support which was somehow missing. Signed-off-by: Arnon Gilboa <[email protected]>
We should prefer the official DataImportCrons and OS images from the OpenShift Virtulization OS images namespace over other namespaces where users may have created test boot sources. Signed-off-by: Arnon Gilboa <[email protected]>
Signed-off-by: Arnon Gilboa <[email protected]>
arnongilboa
force-pushed
the
use_default_dic_ns
branch
from
f388db1 to
1d3ffbd
Compare
ShellyKa13
reviewed
Dec 22, 2024
pkg/internal/checkup/checkup.go
Outdated
| @@ -786,6 +813,13 @@ func (c *Checkup) Config() config.Config { | |||
|
|
|||
| func (c *Checkup) checkVMIBoot(ctx context.Context, errStr *string) error { | |||
| log.Print("checkVMIBoot") | |||
|
|
|||
| if c.defaultStorageClass == "" { | |||
There was a problem hiding this comment.
here you dont need to also check: && c.checkupConfig.StorageClass == "" ?
pkg/internal/checkup/checkup.go
Outdated
| @@ -980,6 +1014,12 @@ func (c *Checkup) checkConcurrentVMIBoot(ctx context.Context, errStr *string) er | |||
| numOfVMs := c.checkupConfig.NumOfVMs | |||
| log.Printf("checkConcurrentVMIBoot numOfVMs:%d", numOfVMs) | |||
|
|
|||
| if c.defaultStorageClass == "" { | |||
| reporter.VMBootFromGoldenImageKey: checkup.MessageSkipNoDefaultStorageClass, | ||
| reporter.ConcurrentVMBootKey: checkup.MessageSkipNoDefaultStorageClass, | ||
| }, | ||
| expectedErr: checkup.ErrNoDefaultStorageClass, | ||
| }, |
There was a problem hiding this comment.
shouldnt you add also virt storage class tests?
There was a problem hiding this comment.
Yes I should :)
| ns := namespaces.Items[i].Name | ||
| if err := c.checkDataImportCrons(ctx, ns, &cs); err != nil { | ||
|
|
||
| if ns, err := c.client.GetNamespace(ctx, defaultGoldenImagesNamespace); err == nil { |
There was a problem hiding this comment.
question, dont you get in the namespaces list also "openshift-virtualization-os-images"? if so why do you need this commit?
There was a problem hiding this comment.
I want to prefer it over other namespaces if we have DataImportCrons there, but use DICs from the other namespaces if not. It can be written as a single loop but it will be a bit more clumsy.
There was a problem hiding this comment.
ah I see that inside checkDataImportCrons you eventually update some values so now I understand
Signed-off-by: Arnon Gilboa <[email protected]>
Signed-off-by: Arnon Gilboa <[email protected]>
This was referenced Jan 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.