Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix checkup inconsistencies #45

Merged

Conversation

arnongilboa
Copy link
Collaborator

Manual cherry-pick of #42

  • Skip checks when no default storage class - the PVC bound and VM checks cannot be executed without default storage class or default virt storage class, so skip them. Also added virt storage class support which was somehow missing.
  • Prefer boot sources (official DataImportCrons and OS images) from the OpenShift Virtulization OS images namespace over other namespaces where users may have created test boot sources.
  • Do not check PVC existence if VM DV source is snapshot.

The PVC bound and VM checks cannot be executed without default storage
class or default virt storage class, so skip them.

Added virt storage class support which was somehow missing.

Signed-off-by: Arnon Gilboa <[email protected]>
We should prefer the official DataImportCrons and OS images from the
OpenShift Virtulization OS images namespace over other namespaces where
users may have created test boot sources.

Signed-off-by: Arnon Gilboa <[email protected]>
@arnongilboa arnongilboa merged commit d79376c into kiagnose:release-0.1 Jan 7, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant