Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add administrator doc in website repo about how to do migration rollback #697

Merged
merged 1 commit into from
Oct 28, 2024
Merged

add administrator doc in website repo about how to do migration rollback #697

merged 1 commit into from
Oct 28, 2024

Conversation

wulemao
Copy link
Contributor

@wulemao wulemao commented Sep 30, 2024 •
edited by RainbowMango
Loading

What type of PR is this?

/kind documentation

What this PR does / why we need it:

add administrator doc in website repo about how to do migration rollback

Which issue(s) this PR fixes:

Part of karmada-io/karmada#5380

Special notes for your reviewer:

@karmada-bot karmada-bot added kind/documentation Categorizes issue or PR as related to documentation. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. labels Sep 30, 2024
@karmada-bot karmada-bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Sep 30, 2024
@chaosi-zju chaosi-zju mentioned this pull request Sep 30, 2024
Closed
7 tasks
@XiShanYongYe-Chang XiShanYongYe-Chang mentioned this pull request Oct 28, 2024
Closed
10 tasks
@karmada-bot karmada-bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Oct 28, 2024
@wulemao wulemao changed the title [WIP] add administrator doc in website repo about how to do migration rollback add administrator doc in website repo about how to do migration rollback Oct 28, 2024
@karmada-bot karmada-bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Oct 28, 2024
@chaosi-zju
Copy link
Member

/lgtm

/cc @RainbowMango @samzong please help a look

@karmada-bot karmada-bot added the lgtm Indicates that a PR is ready to be merged. label Oct 28, 2024
@karmada-bot
Copy link
Collaborator

@chaosi-zju: GitHub didn't allow me to request PR reviews from the following users: a, look, please.

Note that only karmada-io members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to this:

/lgtm

/cc @RainbowMango @samzong please help a look

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

RainbowMango
RainbowMango reviewed Oct 28, 2024
View reviewed changes
Copy link
Member

@RainbowMango RainbowMango left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/assign

RainbowMango
RainbowMango reviewed Oct 28, 2024
View reviewed changes
Copy link
Member

@RainbowMango RainbowMango left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just some nits, otherwise LGTM.

docs/administrator/migration/migrate-in-batch.md Outdated Show resolved Hide resolved
docs/administrator/migration/migrate-in-batch.md Show resolved Hide resolved
docs/administrator/migration/migrate-in-batch.md Outdated Show resolved Hide resolved
@karmada-bot karmada-bot removed the lgtm Indicates that a PR is ready to be merged. label Oct 28, 2024
@wulemao
Copy link
Contributor Author

wulemao commented Oct 28, 2024

all comments fixed

RainbowMango
RainbowMango approved these changes Oct 28, 2024
View reviewed changes
Copy link
Member

@RainbowMango RainbowMango left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@karmada-bot karmada-bot added the lgtm Indicates that a PR is ready to be merged. label Oct 28, 2024
@karmada-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: RainbowMango

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@karmada-bot karmada-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 28, 2024
@karmada-bot karmada-bot merged commit 5abe337 into karmada-io:main Oct 28, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chaosi-zju chaosi-zju chaosi-zju left review comments

@RainbowMango RainbowMango RainbowMango approved these changes

@pigletfly pigletfly Awaiting requested review from pigletfly

@Poor12 Poor12 Awaiting requested review from Poor12

@Tingtal Tingtal Awaiting requested review from Tingtal

@samzong samzong Awaiting requested review from samzong

Assignees

@RainbowMango RainbowMango

@chaosi-zju chaosi-zju

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/documentation Categorizes issue or PR as related to documentation. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@wulemao @chaosi-zju @karmada-bot @RainbowMango