Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Umbrella] Defining resource deleteion policy to support migration rollback #5577

Closed
10 tasks done
XiShanYongYe-Chang opened this issue Sep 21, 2024 · 10 comments
Closed
10 tasks done
Labels
kind/feature Categorizes issue or PR as related to a new feature.
Milestone

Comments

@XiShanYongYe-Chang
Copy link
Member

XiShanYongYe-Chang commented Sep 21, 2024

What would you like to be added:

Provides the ability to roll back migration safely.

Why is this needed:

For specific details, please refer to #5101.

The specific work items can be planned as follows:

@XiShanYongYe-Chang
Copy link
Member Author

Hi @a7i would you like to contribute this feature?
cc @a7i

@XiShanYongYe-Chang
Copy link
Member Author

/kind feature

@karmada-bot karmada-bot added the kind/feature Categorizes issue or PR as related to a new feature. label Sep 21, 2024
@XiShanYongYe-Chang XiShanYongYe-Chang changed the title Defining resource deleteion policy support migration rollback Defining resource deleteion policy to support migration rollback Sep 21, 2024
@a7i
Copy link
Contributor

a7i commented Sep 21, 2024

Hi @a7i would you like to contribute this feature? cc @a7i

Yes absolutely! 🎉

@XiShanYongYe-Chang XiShanYongYe-Chang changed the title Defining resource deleteion policy to support migration rollback [Umbrella] Defining resource deleteion policy to support migration rollback Sep 23, 2024
@wulemao
Copy link
Contributor

wulemao commented Sep 23, 2024

Hi, everybody, I am working on #5380 tasks, which is highly relevant to this issue.

I am interested in this issue too, could you please assign some related test job to me?

@XiShanYongYe-Chang
Copy link
Member Author

Hi @a7i, how about handing over E2E tasks to @wulemao?

@RainbowMango
Copy link
Member

I added one more task, which we should let karmadactl promote leverage this feature to guarantee the promotion can be rolled back safely. To address the issue #3004 sent by @chaunceyjiang .

@wulemao
Copy link
Contributor

wulemao commented Sep 25, 2024

I added one more task, which we should let karmadactl promote leverage this feature to guarantee the promotion can be rolled back safely. To address the issue #3004 sent by @chaunceyjiang .

It is also a very interesting optimization. could I assign for it?

@chaosi-zju
Copy link
Member

@XiShanYongYe-Chang website pr all merged

@RainbowMango RainbowMango added this to the v1.12 milestone Oct 29, 2024
@XiShanYongYe-Chang
Copy link
Member Author

Thanks all~
/close

@karmada-bot
Copy link
Collaborator

@XiShanYongYe-Chang: Closing this issue.

In response to this:

Thanks all~
/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature Categorizes issue or PR as related to a new feature.
Projects
Status: Planned In Release 1.12
Development

No branches or pull requests

6 participants