Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add Support orphan deletion proposal #3328

Closed
wants to merge 1 commit into from

Conversation

Poor12
Copy link
Member

@Poor12 Poor12 commented Mar 25, 2023

What type of PR is this?
/kind design

What this PR does / why we need it:
Add Support orphan deletion proposal.
The requirement of this proposal comes from #3004, discussions on the wechat group and some inconveniences of users in use. I'd like to invite more people to discuss about it.

Which issue(s) this PR fixes:
Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:
None

@karmada-bot karmada-bot added the kind/design Categorizes issue or PR as related to design. label Mar 25, 2023
@karmada-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To complete the pull request process, please assign kevin-wangzefeng after the PR has been reviewed.
You can assign the PR to them by writing /assign @kevin-wangzefeng in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@karmada-bot karmada-bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Mar 25, 2023
@codecov-commenter
Copy link

Codecov Report

Merging #3328 (ecd7f66) into master (a902d8a) will increase coverage by 2.16%.
The diff coverage is n/a.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@            Coverage Diff             @@
##           master    #3328      +/-   ##
==========================================
+ Coverage   49.13%   51.29%   +2.16%     
==========================================
  Files         209      209              
  Lines       18754    18757       +3     
==========================================
+ Hits         9214     9621     +407     
+ Misses       9039     8637     -402     
+ Partials      501      499       -2     
Flag Coverage Δ
unittests 51.29% <ø> (+2.16%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 5 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@Ranler
Copy link

Ranler commented Aug 2, 2023

+1

@RainbowMango
Copy link
Member

/close
In favor of #5577.

@karmada-bot
Copy link
Collaborator

@RainbowMango: Closed this PR.

In response to this:

/close
In favor of #5577.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/design Categorizes issue or PR as related to design. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants