Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

upgrade from v1.9 to v1.10 #622

Merged
merged 1 commit into from
May 30, 2024
Merged

Conversation

zhzhuang-zju
Copy link
Contributor

What type of PR is this?
/kind documentation

What this PR does / why we need it:
Release 1.10 is coming, with new documentation for upgrading from v1.9 to v1.10.

Which issue(s) this PR fixes:
Fixes #

Special notes for your reviewer:

@karmada-bot karmada-bot added the kind/documentation Categorizes issue or PR as related to documentation. label May 29, 2024
@karmada-bot karmada-bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label May 29, 2024
@zhzhuang-zju
Copy link
Contributor Author

/hold
Waiting for local upgrade verification

@karmada-bot karmada-bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 29, 2024
@RainbowMango
Copy link
Member

Please assign it to me once it's ready for review.

@zhzhuang-zju zhzhuang-zju force-pushed the upgrade1.10 branch 2 times, most recently from 51dfb7f to 144bc03 Compare May 30, 2024 12:12
@zhzhuang-zju
Copy link
Contributor Author

/hold cancel

cc @RainbowMango

@karmada-bot karmada-bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 30, 2024
Comment on lines 11 to 13
* Introduced `ServiceAnnotations` to the `Karmada` API to provide an extra set of annotations to annotate karmada apiserver services.
* Add a short name `ric` for resourceinterpretercustomizations CRD resource.
* Introduce a new API named `WorkloadRebalancer` to support rescheduling.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
* Introduced `ServiceAnnotations` to the `Karmada` API to provide an extra set of annotations to annotate karmada apiserver services.
* Add a short name `ric` for resourceinterpretercustomizations CRD resource.
* Introduce a new API named `WorkloadRebalancer` to support rescheduling.
* Introduce a new API named `WorkloadRebalancer` to support rescheduling.
* Introduced `ServiceAnnotations` to the `Karmada` API to provide an extra set of annotations to annotate karmada apiserver services.
* Add a short name `ric` for resourceinterpretercustomizations CRD resource.


### karmada-search

* The feature APIPriorityAndFairness is locked to true, you should remove the flag `--feature-gates=APIPriorityAndFairness=false`.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
* The feature APIPriorityAndFairness is locked to true, you should remove the flag `--feature-gates=APIPriorityAndFairness=false`.
* The feature APIPriorityAndFairness now has moved to GA, thus not allowed to be disabled by feature gates.
You have to remove it from the `--feature-gates` flag.


### karmada-search

* APIPriorityAndFairness 功能已锁定为 true,您应该删除标志 `--feature-gates=APIPriorityAndFairness=false`。
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
* APIPriorityAndFairness 功能已锁定为 true,您应该删除标志 `--feature-gates=APIPriorityAndFairness=false`
* APIPriorityAndFairness 特性已经GA,因此不可以再通过特性开关关闭它,你需要从启动参数`--feature-gates`中删除它

Signed-off-by: zhzhuang-zju <[email protected]>
Copy link
Member

@RainbowMango RainbowMango left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@karmada-bot karmada-bot added the lgtm Indicates that a PR is ready to be merged. label May 30, 2024
@karmada-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: RainbowMango

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@karmada-bot karmada-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 30, 2024
@karmada-bot karmada-bot merged commit 6babe18 into karmada-io:main May 30, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/documentation Categorizes issue or PR as related to documentation. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants