[Umbrella] Use permanent-id to replace namespace/name labels in the resource

[XiShanYongYe-Chang]

What would you like to be added:

Please ref to #4683 (comment)

Why is this needed:

Continue the work of #4000 and break down the tasks to be done.

• Unify and add permanent-id labels to PropagationPolicy/ClusterPropagationPolicy, ResourceBinding/ClusterResourceBinding, and Work resources in karmada-webhook.
  • Add permanent-id for pp, cpp, rb, crb, work in the karmada-webhook @jwcesign @XiShanYongYe-Chang feat: add permanent id label to pp/cpp/rb/crb/work resources #4474
  • Remove the add permanent-id logic in the karmada-controller-manager (we can do it in the next release) @whitewindmills
    • For Work resource cleanup dead code of generating Work permanent id #4928
    • For RB/CRB resource cleanup dead code of generating binding permanent id #4950
    • For PP/CPP resource cleanup dead code of generating PropagationPolicy permanent id #4949
• Replace the use of namespace/name labels in the code with permanent-id labels, including: @whitewindmills @XiShanYongYe-Chang
  • propagationpolicy.karmada.io/namespace, propagationpolicy.karmada.io/name -> propagationpolicy.karmada.io/permanent-id Deprecate name/namespace labels of pp/cpp #4743
  • clusterpropagationpolicy.karmada.io/name -> clusterpropagationpolicy.karmada.io/permanent-id Deprecate name/namespace labels of pp/cpp #4743
  • resourcebinding.karmada.io/key -> resourcebinding.karmada.io/permanent-id Deprecate key labels of rb/crb #4811
  • clusterresourcebinding.karmada.io/key -> clusterresourcebinding.karmada.io/permanent-id Deprecate key labels of rb/crb #4811
  • work.karmada.io/namespace, work.karmada.io/name -> work.karmada.io/permanent-id Deprecate name/namespace labels of work #4813 Remove work label on the member cluster resource #4765 replace work namespace/name labels with annotations #4865
• Clean up the uid labels on the resource: @liangyuanpeng Delete the labels of uid. #4718
  • propagationpolicy.karmada.io/uid
  • clusterpropagationpolicy.karmada.io/uid
  • resourcebinding.karmada.io/uid
  • clusterresourcebinding.karmada.io/uid
  • work.karmada.io/uid
• Deprecated namespace/name labels on resources: @whitewindmills
  • Deprecated propagationpolicy.karmada.io/namespace Deprecate name/namespace labels of pp/cpp #4743
  • Deprecated propagationpolicy.karmada.io/name Deprecate name/namespace labels of pp/cpp #4743
  • Deprecated clusterpropagationpolicy.karmada.io/name Deprecate name/namespace labels of pp/cpp #4743
  • resourcebinding.karmada.io/key Deprecate key labels of rb/crb #4811
  • clusterresourcebinding.karmada.io/key Deprecate key labels of rb/crb #4811
  • work.karmada.io/namespace Deprecate name/namespace labels of work #4813
  • work.karmada.io/name Deprecate name/namespace labels of work #4813
• Add validation for permanent-id @whitewindmills Add validation on policy permanent ID #4964
• Remove those labels: propagationpolicy.karmada.io/namespace, propagationpolicy.karmada.io/name in the v1.11. @XiShanYongYe-Chang Remove pp/cpp namespace/name labels #5020
• The names of PP and CPP are not allowed to exceed 63 characters. This is the verification logic of karmada-webhook:
  

  karmada/pkg/webhook/propagationpolicy/mutating.go

  Lines 74 to 76 in 9822d09

  	if len(policy.Name) > validation.LabelValueMaxLength {
  	return admission.Errored(http.StatusBadRequest, fmt.Errorf("PropagationPolicy's name should be no more than %d characters", validation.LabelValueMaxLength))
  	}

  
  @XiShanYongYe-Chang Remove pp/cpp name length limit #5029

Note: the reason for adding this verification is that the names of PP and CPP will appear in In the resource template and the label value of RB, this check can be removed after we solve the issue.

• Describe the impact of the current task on users and upgrade precautions in the upgrade document. @zhzhuang-zju upgrade from v1.9 to v1.10 website#622

[liangyuanpeng]

I'm interested in this and I want to take care of Clean up the uid labels on the resource And do we plan to issue deprecation warnings to users before removing logic?

[XiShanYongYe-Chang]

I'm interested in this and I want to take care of Clean up the uid labels on the resource.

Thanks a lot~

And do we plan to issue deprecation warnings to users before removing logic?

I think it is necessary, although we have mentioned the need to discard these labels in many community meetings and related issue descriptions and discussions, we still need to find a clear place to describe the text, so that this information can be passed to more users.

Do you have any suggestions?

[XiShanYongYe-Chang]

/help
Anyone interested can pick up the task to develop.

[karmada-bot]

@XiShanYongYe-Chang:
This request has been marked as needing help from a contributor.

Please ensure the request meets the requirements listed here.

If this request no longer meets these requirements, the label can be removed
by commenting with the /remove-help command.

In response to this:

/help
Anyone interested can pick up the task to develop.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[whitewindmills]

I wanna pick up this one Clean up namespace/name labels on resources.

[XiShanYongYe-Chang]

I wanna pick up this one Clean up namespace/name labels on resources.

Ok, thx~

[liangyuanpeng]

I think it is necessary, although we have mentioned the need to discard these labels in many community meetings and related issue descriptions and discussions, we still need to find a clear place to describe the text, so that this information can be passed to more users.
Do you have any suggestions?

Is FeatureGates enough? At least it gives users a chance to be compatible., like :

  //**TODO GA in 1.11, delete the FeatureGate**
 if !FeatureGates.xxx.enabled {
        // TODO: Delete following two lines in release-1.9
	delete(bindingCopy.Labels, workv1alpha2.ResourceBindingUIDLabel)
	delete(bindingCopy.Labels, policyv1alpha1.PropagationPolicyUIDLabel)
 }

cc @chaunceyjiang

[yizhang-zen]

@chaunceyjiang , it seems all the tasks have been picked up. Any input from you and any work that need us?

[XiShanYongYe-Chang]

/assign @liangyuanpeng @whitewindmills @XiShanYongYe-Chang

[XiShanYongYe-Chang]

All sub-tasks have been finished, let's close it.
/close