Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deprecate name/namespace labels of pp/cpp #4743

Merged
merged 1 commit into from
Apr 25, 2024
Merged

Deprecate name/namespace labels of pp/cpp #4743

merged 1 commit into from
Apr 25, 2024

Conversation

whitewindmills
Copy link
Member

@whitewindmills whitewindmills commented Mar 25, 2024 •
edited
Loading

What type of PR is this?
/kind feature
/kind cleanup

What this PR does / why we need it:

propagationpolicy.karmada.io/namespace, propagationpolicy.karmada.io/name -> propagationpolicy.karmada.io/permanent-id
clusterpropagationpolicy.karmada.io/name -> clusterpropagationpolicy.karmada.io/permanent-id

Which issue(s) this PR fixes:
part of issue

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

karmada-controller-manager: deprecate name/namespace labels of pp/cpp.

@karmada-bot karmada-bot added the kind/feature Categorizes issue or PR as related to a new feature. label Mar 25, 2024
@karmada-bot karmada-bot added kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Mar 25, 2024
@codecov-commenter
Copy link

codecov-commenter commented Mar 25, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 0.70423% with 141 lines in your changes are missing coverage. Please review.

Project coverage is 53.11%. Comparing base (1754e73) to head (59b8835).

Files Patch % Lines
pkg/detector/detector.go 0.00% 69 Missing ⚠️
pkg/detector/policy.go 0.00% 46 Missing ⚠️
pkg/detector/preemption.go 0.00% 16 Missing ⚠️
pkg/util/annotation.go 0.00% 7 Missing ⚠️
pkg/scheduler/event_handler.go 0.00% 2 Missing ⚠️
pkg/util/worker.go 0.00% 1 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #4743      +/-   ##
==========================================
+ Coverage   53.07%   53.11%   +0.04%     
==========================================
  Files         250      250              
  Lines       20371    20346      -25     
==========================================
- Hits        10811    10806       -5     
+ Misses       8843     8821      -22     
- Partials      717      719       +2
Flag Coverage Δ
unittests 53.11% <0.70%> (+0.04%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@whitewindmills whitewindmills force-pushed the deprecated-labels branch 2 times, most recently from 9afa5bd to 4f2fa4d Compare March 25, 2024 09:15
@XiShanYongYe-Chang
Copy link
Member

Wow, you submitted a big PR. I found that my newly submitted PR #4748 is part of yours (pp/cpp).

@whitewindmills
Copy link
Member Author

@XiShanYongYe-Chang Maybe it is not easy to split this task. It is easy for conflicts to arise between the codes we submitted. I found that there are some things in your PR that I missed, so how about we co-author this PR?

@XiShanYongYe-Chang
Copy link
Member

@XiShanYongYe-Chang Maybe it is not easy to split this task. It is easy for conflicts to arise between the codes we submitted. I found that there are some things in your PR that I missed, so how about we co-author this PR?

Sure :). What is the specific cooperation mode?

@whitewindmills
Copy link
Member Author

What is the specific cooperation mode?

If you still have unfinished code submission, you can continue to do this work. After the submission is completed, I will cherry-pick your PR and add Co-authored-by: changzhen <[email protected]> to this PR. Finally, we will review this PR together.

@XiShanYongYe-Chang
Copy link
Member

XiShanYongYe-Chang commented Mar 25, 2024 •
edited
Loading

The code has been submitted and is now waiting for the CI to finish. If the CI fails, the CI may need to be fixed.

You can directly cherry-pick and then we modify the CI together.

@whitewindmills
Copy link
Member Author

@XiShanYongYe-Chang okay, thanks for your remainder.

@XiShanYongYe-Chang
Copy link
Member

A priority preemption ci error has occurred. Please help take a look: https://github.com/karmada-io/karmada/actions/runs/8419825470/job/23053518691?pr=4748

/cc @whitewindmills

@karmada-bot
Copy link
Collaborator

@XiShanYongYe-Chang: GitHub didn't allow me to request PR reviews from the following users: whitewindmills.

Note that only karmada-io members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to this:

A priority preemption ci error has occurred. Please help take a look: https://github.com/karmada-io/karmada/actions/runs/8419825470/job/23053518691?pr=4748

/cc @whitewindmills

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@whitewindmills whitewindmills force-pushed the deprecated-labels branch 2 times, most recently from b562e7f to b36e67e Compare March 26, 2024 03:39
@whitewindmills
Copy link
Member Author

@XiShanYongYe-Chang Could you help check if there are any omissions?

@XiShanYongYe-Chang
Copy link
Member

@XiShanYongYe-Chang Could you help check if there are any omissions?

of course
/assign

@karmada-bot karmada-bot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Mar 26, 2024
@whitewindmills whitewindmills force-pushed the deprecated-labels branch 2 times, most recently from ab344b8 to 9a8e94c Compare March 26, 2024 10:51
XiShanYongYe-Chang
XiShanYongYe-Chang reviewed Apr 9, 2024
View reviewed changes
Copy link
Member

@XiShanYongYe-Chang XiShanYongYe-Chang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks~
/lgtm

@karmada-bot karmada-bot added the lgtm Indicates that a PR is ready to be merged. label Apr 9, 2024
RainbowMango
RainbowMango reviewed Apr 10, 2024
View reviewed changes
Copy link
Member

@RainbowMango RainbowMango left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/assign
I will reserve time for this tomorrow.

@RainbowMango
Copy link
Member

@whitewindmills Can you help to rebase this PR? I need to check something made in #4811.

@whitewindmills
Copy link
Member Author

Can you help to rebase this PR?

okay

@karmada-bot karmada-bot removed the lgtm Indicates that a PR is ready to be merged. label Apr 11, 2024
@whitewindmills whitewindmills mentioned this pull request Apr 16, 2024
Merged
@whitewindmills
Copy link
Member Author

Wait for #4836.
/hold

@karmada-bot karmada-bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 16, 2024
@RainbowMango
Copy link
Member

/hold cancel
Please help to rebase this PR as #4836 has been merged.

@karmada-bot karmada-bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 18, 2024
@whitewindmills @XiShanYongYe-Chang
Deprecate name/namespace labels of pp/cpp
59b8835 
Co-authored-by: changzhen <[email protected]>
Signed-off-by: whitewindmills <[email protected]>
XiShanYongYe-Chang
XiShanYongYe-Chang reviewed Apr 19, 2024
View reviewed changes
Copy link
Member

@XiShanYongYe-Chang XiShanYongYe-Chang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@karmada-bot karmada-bot added the lgtm Indicates that a PR is ready to be merged. label Apr 19, 2024
@whitewindmills
Copy link
Member Author

@RainbowMango pls take a look again.

@XiShanYongYe-Chang
Copy link
Member

How about going on to move forward with this?
/cc @RainbowMango @chaunceyjiang

RainbowMango
RainbowMango approved these changes Apr 25, 2024
View reviewed changes
Copy link
Member

@RainbowMango RainbowMango left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@karmada-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: RainbowMango

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@karmada-bot karmada-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 25, 2024
@karmada-bot karmada-bot merged commit 68577f1 into karmada-io:master Apr 25, 2024
12 checks passed
@zhzhuang-zju zhzhuang-zju mentioned this pull request Apr 28, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@XiShanYongYe-Chang XiShanYongYe-Chang XiShanYongYe-Chang left review comments

@RainbowMango RainbowMango RainbowMango approved these changes

@chaunceyjiang chaunceyjiang Awaiting requested review from chaunceyjiang

@lonelyCZ lonelyCZ Awaiting requested review from lonelyCZ

@Poor12 Poor12 Awaiting requested review from Poor12

@qianjun1993 qianjun1993 Awaiting requested review from qianjun1993

@Vacant2333 Vacant2333 Awaiting requested review from Vacant2333

Assignees

@RainbowMango RainbowMango

@XiShanYongYe-Chang XiShanYongYe-Chang

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. kind/feature Categorizes issue or PR as related to a new feature. lgtm Indicates that a PR is ready to be merged. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@whitewindmills @codecov-commenter @XiShanYongYe-Chang @karmada-bot @RainbowMango