Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

e2e: Remove annotaions when pp/cpp is deleted #4561

Merged
merged 1 commit into from
Apr 28, 2024
Merged

e2e: Remove annotaions when pp/cpp is deleted #4561

merged 1 commit into from
Apr 28, 2024

Conversation

zhzhuang-zju
Copy link
Contributor

What type of PR is this?
/kind cleanup

What this PR does / why we need it:
Remove annotaions when pp/cpp is deleted
Which issue(s) this PR fixes:
Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

NONE

@karmada-bot karmada-bot added the kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. label Jan 19, 2024
@karmada-bot karmada-bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Jan 19, 2024
@codecov-commenter
Copy link

codecov-commenter commented Jan 19, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 53.07%. Comparing base (80ee3b2) to head (4842566).

Files Patch % Lines
pkg/detector/detector.go 0.00% 2 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #4561      +/-   ##
==========================================
- Coverage   53.08%   53.07%   -0.01%     
==========================================
  Files         251      251              
  Lines       20387    20387              
==========================================
- Hits        10822    10821       -1     
- Misses       8852     8853       +1     
  Partials      713      713
Flag Coverage Δ
unittests 53.07% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@zhzhuang-zju
Copy link
Contributor Author

cc @Vacant2333 @XiShanYongYe-Chang

@Vacant2333
Copy link
Contributor

@zhzhuang-zju i will help u to review after the ci pass~~~

Vacant2333
Vacant2333 reviewed Jan 23, 2024
View reviewed changes
Copy link
Contributor

@Vacant2333 Vacant2333 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me, can u help to take a look @XiShanYongYe-Chang ~

pkg/detector/detector.go Show resolved Hide resolved
@XiShanYongYe-Chang
Copy link
Member

Thanks a lot
/assign

@zhzhuang-zju zhzhuang-zju changed the title Remove annotaions when pp/cpp is deleted e2e: Remove annotaions when pp/cpp is deleted Apr 28, 2024
@zhzhuang-zju
Copy link
Contributor Author

since #4743 has been merged, so this pr changes to add some related e2e scenarios
@XiShanYongYe-Chang @Vacant2333

XiShanYongYe-Chang
XiShanYongYe-Chang reviewed Apr 28, 2024
View reviewed changes
Copy link
Member

@XiShanYongYe-Chang XiShanYongYe-Chang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot~
/lgtm
/approve

@karmada-bot karmada-bot added the lgtm Indicates that a PR is ready to be merged. label Apr 28, 2024
XiShanYongYe-Chang
XiShanYongYe-Chang reviewed Apr 28, 2024
View reviewed changes
Copy link
Member

@XiShanYongYe-Chang XiShanYongYe-Chang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/assign @RainbowMango

RainbowMango
RainbowMango approved these changes Apr 28, 2024
View reviewed changes
Copy link
Member

@RainbowMango RainbowMango left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

Obviously, we missed to rename it at #4743.

@karmada-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: RainbowMango, XiShanYongYe-Chang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@karmada-bot karmada-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 28, 2024
@karmada-bot karmada-bot merged commit fff3699 into karmada-io:master Apr 28, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chaunceyjiang chaunceyjiang chaunceyjiang left review comments

@Vacant2333 Vacant2333 Vacant2333 left review comments

@XiShanYongYe-Chang XiShanYongYe-Chang XiShanYongYe-Chang left review comments

@RainbowMango RainbowMango RainbowMango approved these changes

Assignees

@RainbowMango RainbowMango

@XiShanYongYe-Chang XiShanYongYe-Chang

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@zhzhuang-zju @codecov-commenter @Vacant2333 @XiShanYongYe-Chang @karmada-bot @RainbowMango @chaunceyjiang