reducing amount of "eventually"s in e2e tests #100
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RamLavi
force-pushed
the
drop_eventually_in_tests
branch
from
38c58ad
to
7e3f78b
Compare
This was referenced Mar 4, 2020
RamLavi
force-pushed
the
drop_eventually_in_tests
branch
from
7e3f78b
to
4a08bf1
Compare
alonSadan
reviewed
Mar 5, 2020
RamLavi
force-pushed
the
drop_eventually_in_tests
branch
2 times, most recently
from
ece37b8
to
974d0db
Compare
RamLavi
changed the title
RamLavi
force-pushed
the
drop_eventually_in_tests
branch
3 times, most recently
from
17399ef
to
8adf567
Compare
phoracek
approved these changes
Mar 26, 2020
|
@RamLavi feel free to cancel the hold |
Signed-off-by: Ram Lavi <[email protected]>
RamLavi
force-pushed
the
drop_eventually_in_tests
branch
from
8adf567
to
2cb2390
Compare
|
/lgtm |
|
@RamLavi: you cannot LGTM your own PR. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: phoracek, RamLavi The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/lgtm |
|
/release-note-none |
kubevirt-bot
added
release-note-none
and removed
do-not-merge/release-note-label-needed
labels
This was referenced Mar 29, 2020
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Most of the kubemacpool tests are using 'Eventually' method.
Using this method may hide bugs (for example).
In this PR we will reexamine the use of eventually in the e2e tests, to achieve the following goal:
As part of opening this PR, we will signal as 'P' tests that show unstable behavior as a result of the removal of eventually - indicating a potential bug. For each there will be opened a corresponding issue.
Signed-off-by: Ram Lavi [email protected]