Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

virtual machine e2e test: testing finalizers sometimes fail #103

Closed
RamLavi opened this issue Mar 4, 2020 · 1 comment
Closed

virtual machine e2e test: testing finalizers sometimes fail #103

RamLavi opened this issue Mar 4, 2020 · 1 comment

Comments

@RamLavi
Copy link
Member

RamLavi commented Mar 4, 2020

Following the exclusion of virtual machine e2e test: testing finalizers in the following PR, this issue has been open to resolve why the test sometimes fail.

test error logs summary are: (full logs attached )

2020-03-01T13:15:31.660Z	ERROR	VirtualMachine Controller	failed to update the VM with the new finalizer	{"virtualMachineName": "testvmsk5jgjwksrv7lrb5wnmdtmtrw9qz2w4s", "virtualMachineNamespace": "kubemacpool-test", "error": "Operation cannot be fulfilled on virtualmachines.kubevirt.io \"testvmsk5jgjwksrv7lrb5wnmdtmtrw9qz2w4s\": the object has been modified; please apply your changes to the latest version and try again"}
github.com/k8snetworkplumbingwg/kubemacpool/vendor/github.com/go-logr/zapr.(*zapLogger).Error
	/go/src/github.com/k8snetworkplumbingwg/kubemacpool/vendor/github.com/go-logr/zapr/zapr.go:128
github.com/k8snetworkplumbingwg/kubemacpool/pkg/controller/virtualmachine.(*ReconcilePolicy).addFinalizerAndUpdate
	/go/src/github.com/k8snetworkplumbingwg/kubemacpool/pkg/controller/virtualmachine/virtualmachine_controller.go:124
github.com/k8snetworkplumbingwg/kubemacpool/pkg/controller/virtualmachine.(*ReconcilePolicy).Reconcile
	/go/src/github.com/k8snetworkplumbingwg/kubemacpool/pkg/controller/virtualmachine/virtualmachine_controller.go:101
github.com/k8snetworkplumbingwg/kubemacpool/vendor/sigs.k8s.io/controller-runtime/pkg/internal/controller.(*Controller).reconcileHandler
	/go/src/github.com/k8snetworkplumbingwg/kubemacpool/vendor/sigs.k8s.io/controller-runtime/pkg/internal/controller/controller.go:256
github.com/k8snetworkplumbingwg/kubemacpool/vendor/sigs.k8s.io/controller-runtime/pkg/internal/controller.(*Controller).processNextWorkItem
	/go/src/github.com/k8snetworkplumbingwg/kubemacpool/vendor/sigs.k8s.io/controller-runtime/pkg/internal/controller/controller.go:232
github.com/k8snetworkplumbingwg/kubemacpool/vendor/sigs.k8s.io/controller-runtime/pkg/internal/controller.(*Controller).worker
	/go/src/github.com/k8snetworkplumbingwg/kubemacpool/vendor/sigs.k8s.io/controller-runtime/pkg/internal/controller/controller.go:211
github.com/k8snetworkplumbingwg/kubemacpool/vendor/k8s.io/apimachinery/pkg/util/wait.JitterUntil.func1
	/go/src/github.com/k8snetworkplumbingwg/kubemacpool/vendor/k8s.io/apimachinery/pkg/util/wait/wait.go:152
github.com/k8snetworkplumbingwg/kubemacpool/vendor/k8s.io/apimachinery/pkg/util/wait.JitterUntil
	/go/src/github.com/k8snetworkplumbingwg/kubemacpool/vendor/k8s.io/apimachinery/pkg/util/wait/wait.go:153
github.com/k8snetworkplumbingwg/kubemacpool/vendor/k8s.io/apimachinery/pkg/util/wait.Until
	/go/src/github.com/k8snetworkplumbingwg/kubemacpool/vendor/k8s.io/apimachinery/pkg/util/wait/wait.go:88
2020-03-01T13:15:31.660Z	ERROR	controller-runtime.controller	Reconciler error	{"controller": "virtualmachine-controller", "request": "kubemacpool-test/testvmsk5jgjwksrv7lrb5wnmdtmtrw9qz2w4s", "error": "Operation cannot be fulfilled on virtualmachines.kubevirt.io \"testvmsk5jgjwksrv7lrb5wnmdtmtrw9qz2w4s\": the object has been modified; please apply your changes to the latest version and try again"}
github.com/k8snetworkplumbingwg/kubemacpool/vendor/github.com/go-logr/zapr.(*zapLogger).Error
	/go/src/github.com/k8snetworkplumbingwg/kubemacpool/vendor/github.com/go-logr/zapr/zapr.go:128
github.com/k8snetworkplumbingwg/kubemacpool/vendor/sigs.k8s.io/controller-runtime/pkg/internal/controller.(*Controller).reconcileHandler
	/go/src/github.com/k8snetworkplumbingwg/kubemacpool/vendor/sigs.k8s.io/controller-runtime/pkg/internal/controller/controller.go:258
github.com/k8snetworkplumbingwg/kubemacpool/vendor/sigs.k8s.io/controller-runtime/pkg/internal/controller.(*Controller).processNextWorkItem
	/go/src/github.com/k8snetworkplumbingwg/kubemacpool/vendor/sigs.k8s.io/controller-runtime/pkg/internal/controller/controller.go:232
github.com/k8snetworkplumbingwg/kubemacpool/vendor/sigs.k8s.io/controller-runtime/pkg/internal/controller.(*Controller).worker
	/go/src/github.com/k8snetworkplumbingwg/kubemacpool/vendor/sigs.k8s.io/controller-runtime/pkg/internal/controller/controller.go:211
github.com/k8snetworkplumbingwg/kubemacpool/vendor/k8s.io/apimachinery/pkg/util/wait.JitterUntil.func1
	/go/src/github.com/k8snetworkplumbingwg/kubemacpool/vendor/k8s.io/apimachinery/pkg/util/wait/wait.go:152
github.com/k8snetworkplumbingwg/kubemacpool/vendor/k8s.io/apimachinery/pkg/util/wait.JitterUntil
	/go/src/github.com/k8snetworkplumbingwg/kubemacpool/vendor/k8s.io/apimachinery/pkg/util/wait/wait.go:153
github.com/k8snetworkplumbingwg/kubemacpool/vendor/k8s.io/apimachinery/pkg/util/wait.Until
	/go/src/github.com/k8snetworkplumbingwg/kubemacpool/vendor/k8s.io/apimachinery/pkg/util/wait/wait.go:88

Service: &Service{ObjectMeta:{kubemacpool-service  kubemacpool-system /api/v1/namespaces/kubemacpool-system/services/kubemacpool-service 304f234e-0050-416f-8c1a-fa6717c49d0e 24801 0 2020-03-01 14:53:35 +0200 IST <nil> <nil> map[] map[kubectl.kubernetes.io/last-applied-configuration:{"apiVersion":"v1","kind":"Service","metadata":{"annotations":{},"name":"kubemacpool-service","namespace":"kubemacpool-system"},"spec":{"ports":[{"port":443,"targetPort":8000}],"publishNotReadyAddresses":true,"selector":{"kubemacpool-leader":"true"}}}
] [{apps/v1 Deployment kubemacpool-mac-controller-manager b5a8d87d-8575-4564-a371-53b95fc267b4 <nil> <nil>}] []  []},Spec:ServiceSpec{Ports:[]ServicePort{ServicePort{Name:,Protocol:TCP,Port:443,TargetPort:{0 8000 },NodePort:0,},},Selector:map[string]string{kubemacpool-leader: true,},ClusterIP:10.96.76.246,Type:ClusterIP,ExternalIPs:[],SessionAffinity:None,LoadBalancerIP:,LoadBalancerSourceRanges:[],ExternalName:,ExternalTrafficPolicy:,HealthCheckNodePort:0,PublishNotReadyAddresses:true,SessionAffinityConfig:nil,IPFamily:nil,},Status:ServiceStatus{LoadBalancer:LoadBalancerStatus{Ingress:[]LoadBalancerIngress{},},},}Endpoint: &Endpoints{ObjectMeta:{kubemacpool-service  kubemacpool-system /api/v1/namespaces/kubemacpool-system/endpoints/kubemacpool-service f4003912-b32c-4136-974d-49be16947818 30345 0 2020-03-01 14:53:35 +0200 IST <nil> <nil> map[] map[endpoints.kubernetes.io/last-change-trigger-time:2020-03-01T13:15:31Z] [] []  []},Subsets:[]EndpointSubset{EndpointSubset{Addresses:[]EndpointAddress{EndpointAddress{IP:10.244.0.40,TargetRef:&ObjectReference{Kind:Pod,Namespace:kubemacpool-system,Name:kubemacpool-mac-controller-manager-6dd6599854-wk7g7,UID:01c1a72f-ba88-4d82-b6de-7e58b258a58b,APIVersion:,ResourceVersion:30344,FieldPath:,},Hostname:,NodeName:*node01,},},NotReadyAddresses:[]EndpointAddress{},Ports:[]EndpointPort{EndpointPort{Name:,Port:8000,Protocol:TCP,},},},},}• Failure [21.320 seconds]
Virtual Machines
/root/github.com/k8snetworkplumbingwg/kubemacpool/tests/virtual_machines_test.go:24
  Check the client
  /root/github.com/k8snetworkplumbingwg/kubemacpool/tests/virtual_machines_test.go:34
    testing finalizers
    /root/github.com/k8snetworkplumbingwg/kubemacpool/tests/virtual_machines_test.go:359
      When the VM is not being deleted
      /root/github.com/k8snetworkplumbingwg/kubemacpool/tests/virtual_machines_test.go:360
        should have a finalizer and deletion timestamp should be zero  [It]
        /root/github.com/k8snetworkplumbingwg/kubemacpool/tests/virtual_machines_test.go:361

        Expected
            <bool>: false
        to equal
            <bool>: true

        /root/github.com/k8snetworkplumbingwg/kubemacpool/vendor/github.com/onsi/gomega/internal/assertion/assertion.go:38```
@alonSadan
Copy link
Contributor

This PR relates to that issue:
#111

@RamLavi RamLavi closed this as completed Apr 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants