Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix / accessibility bugs and form validation #500

Conversation

MelissaDTH
Copy link
Contributor

@MelissaDTH MelissaDTH commented Apr 16, 2024

Description

This pull request includes recent accessibility improvements implemented in the Videodock/ott-web-app fork. It includes validation improvements and an update to the IconButton component, see below:

Implemented fixes

  • Enhances form validation on the Account page
  • Fixes an issue with the old password form where errors persisted after validation
  • Updates the IconButton component to utilise a <button> element instead of a <div> element, this improves its accessibility by providing a more semantically correct representation of a clickable button, ensuring that aria attributes function as intended
    • Also ensures adherence to button styling and prevents them from acting as a submit button after the above fix

Commits

  • fix(project): improve form validation on account page
  • fix(project): old password form error after validation
  • fix(a11y): icon button to use button element
  • chore(a11y): adhere icon button styling & don’t act as a submit button
  • fix(a11y): focus not returned when closing the main menu using VoiceOver

Steps completed:

According to our definition of done, I have completed the following steps:

  • Acceptance criteria met
  • Unit tests added
  • Docs updated (including config and env variables)
  • Translations added
  • UX tested
  • Browsers / platforms tested
  • Rebased & ready to merge without conflicts
  • Reviewed own code

@ChristiaanScheermeijer ChristiaanScheermeijer force-pushed the feat/accessibility-and-validation-fixes branch from 4c0a198 to 19e2a36 Compare April 16, 2024 12:16
@AntonLantukh
Copy link
Collaborator

@MelissaDTH could you please take a look? The PR looks good, just some minor things I wanted to clarify.

@AntonLantukh AntonLantukh merged commit bf7aa66 into jwplayer:develop Apr 18, 2024
8 of 9 checks passed
@royschut royschut deleted the feat/accessibility-and-validation-fixes branch April 18, 2024 15:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants