fix(a11y): close menu focus with voice over

jwplayer · Apr 18, 2024 · bf7aa66 · bf7aa66
1 parent 1a0f357
commit bf7aa66
Show file tree

Hide file tree

Showing 3 changed files with 1 addition and 14 deletions.
diff --git a/packages/ui-react/src/components/Header/Header.tsx b/packages/ui-react/src/components/Header/Header.tsx
@@ -226,14 +226,7 @@ const Header: React.FC<Props> = ({
           {t('skip_to_content')}
         </a>
         <div className={styles.menu}>
-          <IconButton
-            className={styles.iconButton}
-            aria-label={sideBarOpen ? t('close_menu') : t('open_menu')}
-            aria-controls="sidebar"
-            aria-haspopup="true"
-            aria-expanded={sideBarOpen}
-            onClick={() => onMenuButtonClick()}
-          >
+          <IconButton className={styles.iconButton} aria-label={t('open_menu')} aria-expanded={sideBarOpen} onClick={() => onMenuButtonClick()}>
             <Icon icon={Menu} />
           </IconButton>
         </div>

diff --git a/packages/ui-react/src/components/Header/__snapshots__/Header.test.tsx.snap b/packages/ui-react/src/components/Header/__snapshots__/Header.test.tsx.snap
@@ -18,9 +18,7 @@ exports[`<Header /> > renders header 1`] = `
         class="_menu_f4f7a7"
       >
         <button
-          aria-controls="sidebar"
           aria-expanded="false"
-          aria-haspopup="true"
           aria-label="open_menu"
           class="_iconButton_0fef65 _iconButton_f4f7a7"
           type="button"
@@ -111,9 +109,7 @@ exports[`<Header /> > renders header with nav buttons 1`] = `
         class="_menu_f4f7a7"
       >
         <button
-          aria-controls="sidebar"
           aria-expanded="false"
-          aria-haspopup="true"
           aria-label="open_menu"
           class="_iconButton_0fef65 _iconButton_f4f7a7"
           type="button"

diff --git a/packages/ui-react/src/containers/Layout/__snapshots__/Layout.test.tsx.snap b/packages/ui-react/src/containers/Layout/__snapshots__/Layout.test.tsx.snap
@@ -22,9 +22,7 @@ exports[`<Layout /> > renders layout 1`] = `
             class="_menu_f4f7a7"
           >
             <button
-              aria-controls="sidebar"
               aria-expanded="false"
-              aria-haspopup="true"
               aria-label="open_menu"
               class="_iconButton_0fef65 _iconButton_f4f7a7"
               type="button"