Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include list of merged PRs in dependency bumps for jupyterhub repos #2348

Merged
merged 4 commits into from
Oct 19, 2022

Conversation

manics
Copy link
Member

@manics manics commented Sep 11, 2022

This script takes a repository, current tag/commit/chart-version/docker-tag, new tag/commit/chart-version/docker-tag, and outputs a list of PRs in markdown that is used in a pull request body.

Untested.... though I think it's ready to try.

Closes #2290

@manics manics changed the title WIP: Add script to summarise PRs between a range of git-refs WIP: Include list of merged PRs in dependency bumps for jupyterhub repos Sep 11, 2022
@manics manics force-pushed the dependencies-list-prs branch 2 times, most recently from 2f68ac9 to 8b28d19 Compare September 11, 2022 21:57
@manics manics force-pushed the dependencies-list-prs branch from 8b28d19 to a9d3244 Compare September 11, 2022 22:04
scripts/get-prs.py Outdated Show resolved Hide resolved
@manics manics force-pushed the dependencies-list-prs branch from 2e11baf to a8cdd72 Compare September 12, 2022 22:50
@manics
Copy link
Member Author

manics commented Sep 12, 2022

I've tested this on my fork by pushing an additional commit on a test branch to

  • modify the repo/branch check so that watch-dependencies can run on my fork/branch
  • downgraded some versions to test that PRs are opened

This is the diff I used to test: https://github.com/manics/mybinder.org-deploy/compare/dependencies-list-prs..dependencies-list-prs-test?expand=1

And these are the PRs it's opened: https://github.com/manics/mybinder.org-deploy/pulls/app%2Fgithub-actions
manics#29 and manics#28 are examples of the descriptions with a list of PRs.

@manics manics changed the title WIP: Include list of merged PRs in dependency bumps for jupyterhub repos Include list of merged PRs in dependency bumps for jupyterhub repos Sep 12, 2022
@manics manics marked this pull request as ready for review September 12, 2022 22:57
@manics manics requested a review from consideRatio October 15, 2022 13:59
Copy link
Member

@consideRatio consideRatio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@consideRatio consideRatio merged commit 2f5b421 into jupyterhub:master Oct 19, 2022
@consideRatio
Copy link
Member

Nice work @manics, the result is great: #2367 (comment)

image

@manics manics deleted the dependencies-list-prs branch October 19, 2022 23:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

new upgrade bot loses most useful changelog: binderhub,
2 participants