Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

new upgrade bot loses most useful changelog: binderhub, #2290

Closed
minrk opened this issue Jun 24, 2022 · 2 comments · Fixed by #2348
Closed

new upgrade bot loses most useful changelog: binderhub, #2290

minrk opened this issue Jun 24, 2022 · 2 comments · Fixed by #2348

Comments

@minrk
Copy link
Member

minrk commented Jun 24, 2022

binderhub and repo2docker bumps include the git hash, and henchbot created automatic GitHub compare links to show the changes (extracted hash from image/chart tag and put https://github.com/repo/compare/$before...$after in the body).

It would be handy if our new bot could preserve that functionality, since it's the most relevant change set to have a link to from the PRs.

@manics
Copy link
Member

manics commented Sep 10, 2022

I just started looking into this, I think the easiest way is to pull out the short commit SHA from the image name, e.g. 7580a30..0345a86

-      build_image: quay.io/jupyterhub/repo2docker:2022.02.0-88.g7580a30
+      build_image: quay.io/jupyterhub/repo2docker:2022.02.0-90.g0345a86

and modify https://github.com/executablebooks/github-activity to

@manics
Copy link
Member

manics commented Sep 11, 2022

I decided it'd be easier to write a script: #2348

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants